summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramFragmentFixedFunction.java
diff options
context:
space:
mode:
authorMady Mellor <madym@google.com>2019-03-05 12:16:21 -0800
committerMady Mellor <madym@google.com>2019-03-05 19:17:46 -0800
commit5029fa63e044a13ef36f3a391e2176422ea4074d (patch)
treed315cbabcf6f7138b0e8a76422aae1ff1c469486 /rs/java/android/renderscript/ProgramFragmentFixedFunction.java
parent475f8da097c0589f8bcd148d04c260a5b1030819 (diff)
Fix crash & positioning of notif-based bubbles
We don't need to be adding the row view until the bubble is expanded so I moved the code to where we actually show the view & added a check to remove it from the parent (notif stack scroll layout) if it's attached. Fixes an issue where the expanded state could be in the wrong position. This was because the y calculation for the expanded state happened before it's new height was calculated so it could be incorrect. Test: manual (1) - Have some notif based bubbles - Dismiss the bubble stack - Receive an update for one of those bubbles => SysUI doesn't crash (2) - Have 2 bubbles - Tap on the stack - Tap on the 2nd bubble => Expanded state should be positioned correctly Fixes: 127383589 Fixes: 126550620 Change-Id: Ic2c20d81a2997665810eb9240b28da90f1a9fad5
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions