summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramFragmentFixedFunction.java
diff options
context:
space:
mode:
authorJoanne Chung <joannechung@google.com>2020-07-29 17:36:10 +0800
committerJoanne Chung <joannechung@google.com>2020-07-29 17:36:10 +0800
commit3c7ac7de467fbeb905ed4969a2f2fa59f06f11d1 (patch)
tree99e25e8fce3fec04e272370ebc39f5f2bd25172d /rs/java/android/renderscript/ProgramFragmentFixedFunction.java
parent6f7648c945982a52dc4304e9ee50deb1bcefdeb1 (diff)
Fix "null" toast when FillCallback.onFailure(null) called.
Root cause The error message is set by AutofillService, AutofillService calls FillCallback.onFailure(null) back to the platform. Because a081250 uses String.valueOf(message), this method will make a null object become to a "null" string. This may cause the Autofill session to think we should show message because of a non-null message. And if the AutofillService target SDK is lower than 29, we don't ignore show message, then users will see a "null" toast. Solution Instead of passing the message parameter to String.valueOf() directly , we check the message first, only passing to String.valueOf() if the message is not null. And we pass an empty string if the message parameter is null. Bug: 159888723 Test: Use a test AutofillService which target SDK is lower than 29, make sure no null toast is shown Test: atest CtsAutoFillServiceTestCases:LoginActivityTest#\ testAutofillAgainAfterOnFailure Change-Id: Id7ff581b3a7f35cf97b4f3405a40bfa1a420823e
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions