summaryrefslogtreecommitdiff
path: root/rs/java/android/renderscript/ProgramFragmentFixedFunction.java
diff options
context:
space:
mode:
authorMichal Brzezinski <brzezinski@google.com>2021-09-09 11:23:24 +0100
committerMichal Brzezinski <brzezinski@google.com>2021-09-16 11:45:25 +0100
commit170542defc8cbd30a9c505e187e0c15161352f2e (patch)
tree510ae5dd9d77a6ebd4fb4c3d6ea5070ce72adde5 /rs/java/android/renderscript/ProgramFragmentFixedFunction.java
parent61246e7f0051758289a7423984a0b19a42f9c7c3 (diff)
Making multiuser button work in collapsed QS in split shade
The issue was caused by MultiUserSwitchController always having reference and acting upon multiuser button in expanded QS - that's a different button than collapsed QS. That reference was provided by dagger and while this issue could be fixed in dagger, that would require providing separate multiuser button and separate MultiUserSwitchController. That would require adding qualifier like @Named in multiple places (both providers and receivers) so seems like too much boilerplate (or opportunity for separate module?) and I went with adding factory for MultiUserSwitchController. Another issue is MultiUserSwitchController opening multiuser detail always in expanded QS - collapsed QS currently doesn't support opening detail view. Looks like that requires non-trivial code changes, so for now I did it in a hacky way - forcing panel to expand and only then showing multiuser detail (as seen in QSPanelController). I think this hacky way is better than having non-functioning button. Fixes: 196805122 Test: enable multiuser support -> expand split shade (but not expand QS) -> click on multiuser button -> multiuser panel should open within QS Change-Id: I76c9bb77c870b8a1a4e25221c63821786057d7f2 Merged-In: I76c9bb77c870b8a1a4e25221c63821786057d7f2
Diffstat (limited to 'rs/java/android/renderscript/ProgramFragmentFixedFunction.java')
0 files changed, 0 insertions, 0 deletions