diff options
author | Dave Mankoff <mankoff@google.com> | 2021-03-17 13:31:34 -0400 |
---|---|---|
committer | Dave Mankoff <mankoff@google.com> | 2021-03-18 09:29:29 -0400 |
commit | 4124a204c6660a5007d05205173870dbc409c514 (patch) | |
tree | a0cbd2173e8f0e68f8fd3588910cdec2aa98e66d /packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java | |
parent | fa304e1f71854ab7eca9ece1806acbc52b9d869d (diff) |
Add more logging for falsing.
Makes the FalsingManager slightly less stateful (passing the
interaction type directly to the classifiers as needed). It also
includes more logging than we had before, listing all the failed
classifiers for a gesture, along with the HistoryTracker's
belief and confidence.
Logs are now delayed one gesture. Instead of immediately logging when
a falsing call is made, it waits until the gesture is marked as
complete. This confers two advantages:
1) If multiple calls to #isFalseGesture (and similar) are made, we
don't log multiple times. We only log the result once.
2) It allows us to log the effects on the HistoryTracker, as that only
updates itself when the gesture is marked as completed.
Bug: 172655679
Test: atest SystemUITests && manual
Change-Id: I653ac2abb03a91ff000b46075e58137b04226023
Diffstat (limited to 'packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java')
-rw-r--r-- | packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java b/packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java index 4f48bb4f3260..e16c01a4aa36 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardPatternViewController.java @@ -109,7 +109,7 @@ public class KeyguardPatternViewController // Treat single-sized patterns as erroneous taps. if (pattern.size() == 1) { mFalsingCollector.updateFalseConfidence(FalsingClassifier.Result.falsed( - 0.7, "empty pattern input")); + 0.7, getClass().getSimpleName(), "empty pattern input")); } mLockPatternView.enableInput(); onPatternChecked(userId, false, 0, false /* not valid - too short */); |