diff options
author | Dave Mankoff <mankoff@google.com> | 2020-09-14 12:20:41 -0400 |
---|---|---|
committer | Dave Mankoff <mankoff@google.com> | 2020-09-16 16:27:56 -0400 |
commit | 4a3d8000168accd9bdc431ddd8599fdd299bbcaa (patch) | |
tree | f0851d4e160ce3cca5f1ff24d4b4fe220703c4af /packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java | |
parent | 720c7c6eff34fd005f130f39f5ab8d63ba8b9ced (diff) |
9/N Clean Up Keyguard Class Structure
KeyguardInputView no longer implements KeyguardSecurityView.
This cl seeks to clean up some of the lingering vestiges from this
large chain of refactors.
I have manually tested none, swipe, pattern, pin, and password views
for successfully unlocking, as well as multiple failed attempts
resulting in temporary lock outs.
Fixes: 166448040
Test: atest SystemUITests && manual
Change-Id: I36275598001184e774677cf2dbb16dec8dc7ab5b
Diffstat (limited to 'packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java')
-rw-r--r-- | packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java | 68 |
1 files changed, 2 insertions, 66 deletions
diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java b/packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java index 8baee3b306ef..bdcf467c2456 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardPatternView.java @@ -16,7 +16,6 @@ package com.android.keyguard; import android.content.Context; -import android.content.res.ColorStateList; import android.graphics.Rect; import android.os.SystemClock; import android.text.TextUtils; @@ -27,7 +26,6 @@ import android.view.ViewGroup; import android.view.animation.AnimationUtils; import android.view.animation.Interpolator; -import com.android.internal.widget.LockPatternUtils; import com.android.internal.widget.LockPatternView; import com.android.settingslib.animation.AppearAnimationCreator; import com.android.settingslib.animation.AppearAnimationUtils; @@ -58,7 +56,6 @@ public class KeyguardPatternView extends KeyguardInputView private final Rect mLockPatternScreenBounds = new Rect(); private LockPatternView mLockPatternView; - private KeyguardSecurityCallback mCallback; /** * Keeps track of the last time we poked the wake lock during dispatching of the touch event. @@ -71,7 +68,6 @@ public class KeyguardPatternView extends KeyguardInputView KeyguardMessageArea mSecurityMessageDisplay; private View mEcaView; private ViewGroup mContainer; - private int mDisappearYTranslation; public KeyguardPatternView(Context context) { this(context, null); @@ -91,17 +87,6 @@ public class KeyguardPatternView extends KeyguardInputView (long) (125 * DISAPPEAR_MULTIPLIER_LOCKED), 1.2f /* translationScale */, 0.6f /* delayScale */, AnimationUtils.loadInterpolator( mContext, android.R.interpolator.fast_out_linear_in)); - mDisappearYTranslation = getResources().getDimensionPixelSize( - R.dimen.disappear_y_translation); - } - - @Override - public void setKeyguardCallback(KeyguardSecurityCallback callback) { - mCallback = callback; - } - - @Override - public void setLockPatternUtils(LockPatternUtils utils) { } @Override @@ -148,46 +133,11 @@ public class KeyguardPatternView extends KeyguardInputView } @Override - public void reset() { - } - - @Override - public void showUsabilityHint() { - } - - @Override - public boolean disallowInterceptTouch(MotionEvent event) { + boolean disallowInterceptTouch(MotionEvent event) { return !mLockPatternView.isEmpty() || mLockPatternScreenBounds.contains((int) event.getRawX(), (int) event.getRawY()); } - @Override - public boolean needsInput() { - return false; - } - - @Override - public void onPause() { - } - - @Override - public void onResume(int reason) { - } - - @Override - public KeyguardSecurityCallback getCallback() { - return mCallback; - } - - @Override - public void showPromptReason(int reason) { - } - - @Override - public void showMessage(CharSequence message, ColorStateList colorState) { - } - - @Override public void startAppearAnimation() { enableClipping(false); setAlpha(1f); @@ -196,12 +146,7 @@ public class KeyguardPatternView extends KeyguardInputView 0, mAppearAnimationUtils.getInterpolator()); mAppearAnimationUtils.startAnimation2d( mLockPatternView.getCellStates(), - new Runnable() { - @Override - public void run() { - enableClipping(true); - } - }, + () -> enableClipping(true), this); if (!TextUtils.isEmpty(mSecurityMessageDisplay.getText())) { mAppearAnimationUtils.createAnimation(mSecurityMessageDisplay, 0, @@ -213,15 +158,6 @@ public class KeyguardPatternView extends KeyguardInputView } } - /** - * @deprecated Use {@link #startDisappearAnimation(boolean, Runnable)} - */ - @Override - public boolean startDisappearAnimation(Runnable finishRunnable) { - // TODO(b/166448040): remove this when possible - return false; - } - public boolean startDisappearAnimation(boolean needsSlowUnlockTransition, final Runnable finishRunnable) { float durationMultiplier = needsSlowUnlockTransition ? DISAPPEAR_MULTIPLIER_LOCKED : 1f; |