diff options
author | Felipe Leme <felipeal@google.com> | 2016-04-12 17:28:06 -0700 |
---|---|---|
committer | Felipe Leme <felipeal@google.com> | 2016-04-12 17:28:06 -0700 |
commit | a43d139359346ad57604e8335d92de57f3d47171 (patch) | |
tree | b5f53fab2246f65f069e7448aa506f942080afb4 /packages/Shell/tests | |
parent | 1fe7dfa66aaf37045c62094438ab3db2ee5403c5 (diff) |
Removed redundant notification title.
When a bugreport is finished with a pending notification, it already
display a subtext explaining the situation - not only the extra title is
redundant, but it's too large.
BUG: 27583025
Change-Id: I8d8171faf7b8b86b34f6d860555839918be10550
Diffstat (limited to 'packages/Shell/tests')
-rw-r--r-- | packages/Shell/tests/src/com/android/shell/BugreportReceiverTest.java | 21 |
1 files changed, 4 insertions, 17 deletions
diff --git a/packages/Shell/tests/src/com/android/shell/BugreportReceiverTest.java b/packages/Shell/tests/src/com/android/shell/BugreportReceiverTest.java index 3b5305527ba5..3eb7754aff41 100644 --- a/packages/Shell/tests/src/com/android/shell/BugreportReceiverTest.java +++ b/packages/Shell/tests/src/com/android/shell/BugreportReceiverTest.java @@ -131,9 +131,6 @@ public class BugreportReceiverTest extends InstrumentationTestCase { private static final boolean RENAMED_SCREENSHOTS = true; private static final boolean DIDNT_RENAME_SCREENSHOTS = false; - private static final boolean PENDING_SCREENSHOT = true; - private static final boolean NOT_PENDING_SCREENSHOT = false; - private String mDescription; private String mPlainTextPath; @@ -432,7 +429,7 @@ public class BugreportReceiverTest extends InstrumentationTestCase { sendBugreportStarted(ID2, PID2, NAME2, 1000); sendBugreportFinished(ID, mZipPath, mScreenshotPath); - Bundle extras = acceptBugreportAndGetSharedIntent(ID, PENDING_SCREENSHOT); + Bundle extras = acceptBugreportAndGetSharedIntent(ID); detailsUi = new DetailsUi(mUiBot, ID2); detailsUi.assertName(NAME2); @@ -623,7 +620,7 @@ public class BugreportReceiverTest extends InstrumentationTestCase { private Bundle sendBugreportFinishedAndGetSharedIntent(int id, String bugreportPath, String screenshotPath) { sendBugreportFinished(id, bugreportPath, screenshotPath); - return acceptBugreportAndGetSharedIntent(id, NOT_PENDING_SCREENSHOT); + return acceptBugreportAndGetSharedIntent(id); } /** @@ -632,11 +629,7 @@ public class BugreportReceiverTest extends InstrumentationTestCase { * @return extras sent in the shared intent. */ private Bundle acceptBugreportAndGetSharedIntent(int id) { - return acceptBugreportAndGetSharedIntent(id, NOT_PENDING_SCREENSHOT); - } - - private Bundle acceptBugreportAndGetSharedIntent(int id, boolean pendingScreenshot) { - acceptBugreport(id, pendingScreenshot); + acceptBugreport(id); mUiBot.chooseActivity(UI_NAME); return mListener.getExtras(); } @@ -652,13 +645,7 @@ public class BugreportReceiverTest extends InstrumentationTestCase { * Accepts the notification to share the finished bugreport. */ private void acceptBugreport(int id) { - acceptBugreport(id, NOT_PENDING_SCREENSHOT); - } - - private void acceptBugreport(int id, boolean pendingScreenshot) { - final int res = pendingScreenshot ? R.string.bugreport_finished_pending_screenshot_title - : R.string.bugreport_finished_title; - mUiBot.clickOnNotification(mContext.getString(res, id)); + mUiBot.clickOnNotification(mContext.getString(R.string.bugreport_finished_title, id)); } /** |