summaryrefslogtreecommitdiff
path: root/packages/Shell/src
diff options
context:
space:
mode:
authorRhed Jao <rhedjao@google.com>2021-01-06 17:17:56 +0800
committerRhed Jao <rhedjao@google.com>2021-01-07 14:19:18 +0800
commitfe41c8a0ce421cf9d6d2adad61af72a0fd570043 (patch)
treee672f7b8dae74fd8519ff41c978df56d84e1b8ad /packages/Shell/src
parent61e082abdb166e2cce4e8b48c818874b56411012 (diff)
Fix missing fields when parceling the BugreportInfo
Shell app exception resulted from two missing fields in BugreportInfo when it's parceling. Application ran into the duplicate logic to send notification and start foreground service then caused the exception. Bug: 176624074 Test: Request a bugreport; kill the com.android.shell; \ tap the share notification Change-Id: Ia80f5e77f5486addf9ea7822f566c3fd7d75f42a
Diffstat (limited to 'packages/Shell/src')
-rw-r--r--packages/Shell/src/com/android/shell/BugreportProgressService.java10
1 files changed, 8 insertions, 2 deletions
diff --git a/packages/Shell/src/com/android/shell/BugreportProgressService.java b/packages/Shell/src/com/android/shell/BugreportProgressService.java
index 63b9bb39cba0..16a6061caed2 100644
--- a/packages/Shell/src/com/android/shell/BugreportProgressService.java
+++ b/packages/Shell/src/com/android/shell/BugreportProgressService.java
@@ -2094,8 +2094,10 @@ public class BugreportProgressService extends Service {
name = in.readString();
initialName = in.readString();
title = in.readString();
+ shareTitle = in.readString();
description = in.readString();
progress.set(in.readInt());
+ lastProgress.set(in.readInt());
lastUpdate.set(in.readLong());
formattedLastUpdate = in.readString();
bugreportFile = readFile(in);
@@ -2106,9 +2108,10 @@ public class BugreportProgressService extends Service {
}
finished.set(in.readInt() == 1);
+ addingDetailsToZip = in.readBoolean();
+ addedDetailsToZip = in.readBoolean();
screenshotCounter = in.readInt();
shareDescription = in.readString();
- shareTitle = in.readString();
type = in.readInt();
}
@@ -2119,8 +2122,10 @@ public class BugreportProgressService extends Service {
dest.writeString(name);
dest.writeString(initialName);
dest.writeString(title);
+ dest.writeString(shareTitle);
dest.writeString(description);
dest.writeInt(progress.intValue());
+ dest.writeInt(lastProgress.intValue());
dest.writeLong(lastUpdate.longValue());
dest.writeString(getFormattedLastUpdate());
writeFile(dest, bugreportFile);
@@ -2131,9 +2136,10 @@ public class BugreportProgressService extends Service {
}
dest.writeInt(finished.get() ? 1 : 0);
+ dest.writeBoolean(addingDetailsToZip);
+ dest.writeBoolean(addedDetailsToZip);
dest.writeInt(screenshotCounter);
dest.writeString(shareDescription);
- dest.writeString(shareTitle);
dest.writeInt(type);
}