diff options
author | Nandana Dutt <nandana@google.com> | 2019-08-07 13:45:36 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-08-07 13:45:36 +0000 |
commit | cbdb10f982320a8363beb338324c26d2ca9f064f (patch) | |
tree | 49f4738f7b9dee1a5d717ceea50b295264909987 /packages/Shell/src | |
parent | 0473b08b6bee3da76b9bc300ba941b20159a22e0 (diff) | |
parent | 47c5ecc50ad6b9a87e6c8876f4a215dcd72f1daa (diff) |
Merge "Remove obsolete methods from DumpstateListener implementations"
Diffstat (limited to 'packages/Shell/src')
-rw-r--r-- | packages/Shell/src/com/android/shell/BugreportProgressService.java | 51 |
1 files changed, 7 insertions, 44 deletions
diff --git a/packages/Shell/src/com/android/shell/BugreportProgressService.java b/packages/Shell/src/com/android/shell/BugreportProgressService.java index 1060c7b7ce79..3750a8a1ae75 100644 --- a/packages/Shell/src/com/android/shell/BugreportProgressService.java +++ b/packages/Shell/src/com/android/shell/BugreportProgressService.java @@ -175,9 +175,9 @@ public class BugreportProgressService extends Service { // Passed to Message.obtain() when msg.arg2 is not used. private static final int UNUSED_ARG2 = -2; - // Maximum progress displayed (like 99.00%). - private static final int CAPPED_PROGRESS = 9900; - private static final int CAPPED_MAX = 10000; + // Maximum progress displayed in %. + private static final int CAPPED_PROGRESS = 99; + private static final int CAPPED_MAX = 100; /** Show the progress log every this percent. */ private static final int LOG_PROGRESS_STEP = 10; @@ -1954,7 +1954,10 @@ public class BugreportProgressService extends Service { @Override public void onProgress(int progress) throws RemoteException { - updateProgressInfo(progress, 100 /* progress is already a percentage; so max = 100 */); + if (progress > CAPPED_PROGRESS) { + progress = CAPPED_PROGRESS; + } + updateProgressInfo(progress, CAPPED_MAX); } @Override @@ -1967,46 +1970,6 @@ public class BugreportProgressService extends Service { // TODO(b/111441001): implement } - @Override - public void onProgressUpdated(int progress) throws RemoteException { - /* - * Checks whether the progress changed in a way that should be displayed to the user: - * - info.progress / info.max represents the displayed progress - * - info.realProgress / info.realMax represents the real progress - * - since the real progress can decrease, the displayed progress is only updated if it - * increases - * - the displayed progress is capped at a maximum (like 99%) - */ - info.realProgress = progress; - final int oldPercentage = (CAPPED_MAX * info.progress) / info.max; - int newPercentage = (CAPPED_MAX * info.realProgress) / info.realMax; - int max = info.realMax; - - if (newPercentage > CAPPED_PROGRESS) { - progress = newPercentage = CAPPED_PROGRESS; - max = CAPPED_MAX; - } - - if (newPercentage > oldPercentage) { - updateProgressInfo(progress, max); - } - } - - @Override - public void onMaxProgressUpdated(int maxProgress) throws RemoteException { - Log.d(TAG, "onMaxProgressUpdated: " + maxProgress); - info.realMax = maxProgress; - } - - @Override - public void onSectionComplete(String title, int status, int size, int durationMs) - throws RemoteException { - if (DEBUG) { - Log.v(TAG, "Title: " + title + " Status: " + status + " Size: " + size - + " Duration: " + durationMs + "ms"); - } - } - public void dump(String prefix, PrintWriter pw) { pw.print(prefix); pw.print("token: "); pw.println(token); } |