diff options
author | Yo Chiang <yochiang@google.com> | 2020-02-21 11:53:15 +0800 |
---|---|---|
committer | Yo Chiang <yochiang@google.com> | 2020-02-21 04:17:51 +0000 |
commit | f8d67892332a535338cfd415340a83b31b373ee5 (patch) | |
tree | 0ab384c9c48f05928e9746106df4186c7c6d90a0 /packages/DynamicSystemInstallationService/src | |
parent | a975b9a901f69843758d403aa804d2c014b3067c (diff) |
Fix VerificationActivity Intent
VerificationActivity crashes when the Intent sent to it doesn't have an
extras Bundle. This is because VerificationActivity copies the incoming
Intents extras Bundle with getExtras() / putExtras(Bundle), and
putExtras(Bundle) doesn't expect a null Bundle.
Bug: 145891687
Test: adb shell am start-activity \
-n com.android.dynsystem/com.android.dynsystem.VerificationActivity \
-a android.os.image.action.START_INSTALL \
-d file:///storage/emulated/0/Download/aosp_arm64-dsu_test.zip
Test: Dynamic system service mustn't crash
Change-Id: I111641f366d50d739b922bcc3a52993c44212759
Diffstat (limited to 'packages/DynamicSystemInstallationService/src')
-rw-r--r-- | packages/DynamicSystemInstallationService/src/com/android/dynsystem/VerificationActivity.java | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/packages/DynamicSystemInstallationService/src/com/android/dynsystem/VerificationActivity.java b/packages/DynamicSystemInstallationService/src/com/android/dynsystem/VerificationActivity.java index e42ded74acd0..82ea7449bf6d 100644 --- a/packages/DynamicSystemInstallationService/src/com/android/dynsystem/VerificationActivity.java +++ b/packages/DynamicSystemInstallationService/src/com/android/dynsystem/VerificationActivity.java @@ -84,7 +84,6 @@ public class VerificationActivity extends Activity { // retrieve data from calling intent Intent callingIntent = getIntent(); Uri url = callingIntent.getData(); - Bundle extras = callingIntent.getExtras(); if (url != null) { sVerifiedUrl = url.toString(); @@ -96,7 +95,7 @@ public class VerificationActivity extends Activity { intent.setData(url); } intent.setAction(DynamicSystemClient.ACTION_START_INSTALL); - intent.putExtras(extras); + intent.putExtras(callingIntent); Log.d(TAG, "Starting Installation Service"); startServiceAsUser(intent, UserHandle.SYSTEM); |