summaryrefslogtreecommitdiff
path: root/native/android/sharedmem.cpp
diff options
context:
space:
mode:
authorNick Kralevich <nnk@google.com>2019-01-14 13:52:43 -0800
committerNick Kralevich <nnk@google.com>2019-01-14 13:53:40 -0800
commit396497085a02f2988d15d54e22cb531dd76254f0 (patch)
treeaf6cf95b5b33603e47c2230db33e320b2da9feef /native/android/sharedmem.cpp
parent7ae295368dbb3d9b4dfa67231416cfde2bcdadb0 (diff)
sharedmem.cpp: replace dup() with fcntl(F_DUPFD_CLOEXEC)
Replace calls to dup() with fcntl(F_DUPFD_CLOEXEC). The only difference between the two is that O_CLOEXEC is set on the newly duped file descriptor. This helps address file descriptor leaks crossing an exec() boundary. Test: compiles and boots Change-Id: I95218331382b7a3432d31a46c173009dc4df1a6b
Diffstat (limited to 'native/android/sharedmem.cpp')
-rw-r--r--native/android/sharedmem.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/native/android/sharedmem.cpp b/native/android/sharedmem.cpp
index 757aaecab40d..4410bd6fbeed 100644
--- a/native/android/sharedmem.cpp
+++ b/native/android/sharedmem.cpp
@@ -71,7 +71,7 @@ int ASharedMemory_dupFromJava(JNIEnv* env, jobject javaSharedMemory) {
}
int fd = env->CallIntMethod(javaSharedMemory, sSharedMemory.getFd);
if (fd != -1) {
- fd = dup(fd);
+ fd = fcntl(fd, F_DUPFD_CLOEXEC, 0);
}
return fd;
}