diff options
author | Mikhail Naganov <mnaganov@google.com> | 2020-10-01 15:08:00 -0700 |
---|---|---|
committer | Mikhail Naganov <mnaganov@google.com> | 2020-11-24 23:13:08 +0000 |
commit | 8c845dca4ac89c3b73c8eda23e77b407d0bf2464 (patch) | |
tree | 549806557a5afbe33c2e0b8803f8742ad919bc45 /media/jni | |
parent | 5e3a035a3d848aef6813073228b488d4555e994d (diff) |
Convert mask types from uint32_t to enum type
This applies to the following types:
- audio_gain_mode_t;
- audio_flags_mask_t;
- audio_channel_representation_t;
- audio_channel_mask_t;
- audio_devices_t.
Enum types are distinct thus proper overloading on the type
is possible in C++. Also, assignments to enum types are
less prone to errors.
Bug: 169889714
Test: basic audio functionality
Change-Id: I7f32a7c7741dea88fa2fd8a2e7fe50d0c31eb2e7
Merged-In: I7f32a7c7741dea88fa2fd8a2e7fe50d0c31eb2e7
Diffstat (limited to 'media/jni')
-rw-r--r-- | media/jni/audioeffect/android_media_AudioEffect.cpp | 2 | ||||
-rw-r--r-- | media/jni/soundpool/android_media_SoundPool.cpp | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/media/jni/audioeffect/android_media_AudioEffect.cpp b/media/jni/audioeffect/android_media_AudioEffect.cpp index 96961ac21a2d..d55e9d0efffd 100644 --- a/media/jni/audioeffect/android_media_AudioEffect.cpp +++ b/media/jni/audioeffect/android_media_AudioEffect.cpp @@ -331,7 +331,7 @@ android_media_AudioEffect_native_setup(JNIEnv *env, jobject thiz, jobject weak_t } if (deviceType != AUDIO_DEVICE_NONE) { - device.mType = deviceType; + device.mType = (audio_devices_t)deviceType; ScopedUtfChars address(env, deviceAddress); device.mAddress = address.c_str(); } diff --git a/media/jni/soundpool/android_media_SoundPool.cpp b/media/jni/soundpool/android_media_SoundPool.cpp index ca3cc8552990..26725f87bfdc 100644 --- a/media/jni/soundpool/android_media_SoundPool.cpp +++ b/media/jni/soundpool/android_media_SoundPool.cpp @@ -200,7 +200,7 @@ android_media_SoundPool_native_setup(JNIEnv *env, jobject thiz, jobject weakRef, paa->usage = (audio_usage_t) env->GetIntField(jaa, javaAudioAttrFields.fieldUsage); paa->content_type = (audio_content_type_t) env->GetIntField(jaa, javaAudioAttrFields.fieldContentType); - paa->flags = env->GetIntField(jaa, javaAudioAttrFields.fieldFlags); + paa->flags = (audio_flags_mask_t) env->GetIntField(jaa, javaAudioAttrFields.fieldFlags); ALOGV("android_media_SoundPool_native_setup"); auto *ap = new SoundPool(maxChannels, paa); |