diff options
| author | Treehugger Robot <treehugger-gerrit@google.com> | 2020-12-30 11:40:00 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2020-12-30 11:40:00 +0000 |
| commit | 55a580b253107cbbe0a33278203c6a1f85d31aed (patch) | |
| tree | 22d71814981bf104b04f6f06bf62a4f5958a114c /media/jni | |
| parent | eb709b6d88fadf62c15240e84e9fc40990430da6 (diff) | |
| parent | 5b0bfdb03d12d610acf33601e529e87bfb6e021f (diff) | |
Merge "Tuner JNI: Correct memcpy of C2DataIdInfo"
Diffstat (limited to 'media/jni')
| -rw-r--r-- | media/jni/android_media_tv_Tuner.cpp | 5 | ||||
| -rw-r--r-- | media/jni/android_media_tv_Tuner.h | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/media/jni/android_media_tv_Tuner.cpp b/media/jni/android_media_tv_Tuner.cpp index 749f4d195952..04f50114a1e5 100644 --- a/media/jni/android_media_tv_Tuner.cpp +++ b/media/jni/android_media_tv_Tuner.cpp @@ -291,8 +291,9 @@ MQ& Dvr::getDvrMQ() { C2DataIdInfo::C2DataIdInfo(uint32_t index, uint64_t value) : C2Param(kParamSize, index) { CHECK(isGlobal()); CHECK_EQ(C2Param::INFO, kind()); - DummyInfo info{value}; - memcpy(this + 1, static_cast<C2Param *>(&info) + 1, kParamSize - sizeof(C2Param)); + mInfo = StubInfo(value); + memcpy(static_cast<C2Param *>(this) + 1, static_cast<C2Param *>(&mInfo) + 1, + kParamSize - sizeof(C2Param)); } /////////////// MediaEvent /////////////////////// diff --git a/media/jni/android_media_tv_Tuner.h b/media/jni/android_media_tv_Tuner.h index 83e9db796363..fd2995917475 100644 --- a/media/jni/android_media_tv_Tuner.h +++ b/media/jni/android_media_tv_Tuner.h @@ -250,8 +250,9 @@ class C2DataIdInfo : public C2Param { public: C2DataIdInfo(uint32_t index, uint64_t value); private: - typedef C2GlobalParam<C2Info, C2Int64Value, 0> DummyInfo; - static const size_t kParamSize = sizeof(DummyInfo); + typedef C2GlobalParam<C2Info, C2Int64Value, 0> StubInfo; + StubInfo mInfo; + static const size_t kParamSize = sizeof(StubInfo); }; } // namespace android |