diff options
author | Lajos Molnar <lajos@google.com> | 2020-03-09 21:22:44 +0000 |
---|---|---|
committer | Lajos Molnar <lajos@google.com> | 2020-03-09 21:26:35 +0000 |
commit | 5b610e26eb1be054aa144c39ae3045d5f2c3d29c (patch) | |
tree | 679fbf03d7313a7ecc0931931dbf92e3f55edf2a /media/jni/android_media_MediaCodec.cpp | |
parent | 063ea0ad05daabe7ac6c5d7bdee57e08ddeeb5ae (diff) |
Revert "media: lazy MediaCodec.release()"
Revert submission 10446783-mediacodec-lazy-release
Reason for revert: back-to-back video playback jitters
Reverted Changes:
I119945684:stagefright: MediaCodec::releaseAsync()
Ieb4c0b2e1:media: lazy MediaCodec.release()
Bug: 150662913
Change-Id: I9388f90ab7befe8415afa82b6b349318c5bdc2f8
Diffstat (limited to 'media/jni/android_media_MediaCodec.cpp')
-rw-r--r-- | media/jni/android_media_MediaCodec.cpp | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/media/jni/android_media_MediaCodec.cpp b/media/jni/android_media_MediaCodec.cpp index 737c95d73e6c..893e51654b68 100644 --- a/media/jni/android_media_MediaCodec.cpp +++ b/media/jni/android_media_MediaCodec.cpp @@ -242,13 +242,6 @@ void JMediaCodec::release() { }); } -void JMediaCodec::releaseAsync() { - if (mCodec != NULL) { - mCodec->releaseAsync(); - } - mInitStatus = NO_INIT; -} - JMediaCodec::~JMediaCodec() { if (mLooper != NULL) { /* MediaCodec and looper should have been released explicitly already @@ -1131,10 +1124,7 @@ static sp<JMediaCodec> getMediaCodec(JNIEnv *env, jobject thiz) { } static void android_media_MediaCodec_release(JNIEnv *env, jobject thiz) { - sp<JMediaCodec> codec = getMediaCodec(env, thiz); - if (codec != NULL) { - codec->releaseAsync(); - } + setMediaCodec(env, thiz, NULL); } static void throwCodecException(JNIEnv *env, status_t err, int32_t actionCode, const char *msg) { @@ -2807,7 +2797,7 @@ static void android_media_MediaCodec_native_setup( static void android_media_MediaCodec_native_finalize( JNIEnv *env, jobject thiz) { - setMediaCodec(env, thiz, NULL); + android_media_MediaCodec_release(env, thiz); } // MediaCodec.LinearBlock |