diff options
author | David Chen <dwchen@google.com> | 2017-10-16 13:16:34 -0700 |
---|---|---|
committer | David Chen <dwchen@google.com> | 2017-10-20 16:29:59 -0700 |
commit | 1481fe142d36d5f0b36eeebc358d5a8aef7bf28a (patch) | |
tree | 368875377232437bd13d8c3e856b75b640afee08 /libs/services/src | |
parent | 708f1b8cdca593155e4c572ebe2ebc3ee257c84c (diff) |
Changes pulled data to use Parcel objects.
Previously, pulled data was returned as a string. We instead
return the data as an array of StatsLogEventWrapper, which encodes
using the binary-encoded format liblog uses. StatsD uses the same
parsing as for pushed events to convert these. This CL also fixes
the parsing of log_msg since the strings were previously emptied
before we had a chance to read the values.
Note that the cpp-aidl can't support List of Parcelable, so we
have to return the results as an array.
Test: Manual using the new command in StatsService to print results.
Also created a new unit-test by creating a dummy pull code of -1,
but this test is deleted since it required creating a fake output in
StatsCompanionService.
Change-Id: I1cfb9ea081a59292a60e934e8527adc40982ed80
Diffstat (limited to 'libs/services/src')
-rw-r--r-- | libs/services/src/os/StatsLogEventWrapper.cpp | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/libs/services/src/os/StatsLogEventWrapper.cpp b/libs/services/src/os/StatsLogEventWrapper.cpp new file mode 100644 index 000000000000..8b3aa9ab4257 --- /dev/null +++ b/libs/services/src/os/StatsLogEventWrapper.cpp @@ -0,0 +1,45 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include <android/os/StatsLogEventWrapper.h> + +#include <binder/Parcel.h> +#include <binder/Parcelable.h> +#include <binder/Status.h> +#include <utils/RefBase.h> +#include <vector> + +using android::Parcel; +using android::Parcelable; +using android::status_t; +using std::vector; + +namespace android { +namespace os { + +StatsLogEventWrapper::StatsLogEventWrapper(){}; + +status_t StatsLogEventWrapper::writeToParcel(Parcel* out) const { + out->writeByteVector(bytes); + return ::android::NO_ERROR; +}; + +status_t StatsLogEventWrapper::readFromParcel(const Parcel* in) { + in->readByteVector(&bytes); + return ::android::NO_ERROR; +}; + +} // Namespace os +} // Namespace android |