diff options
| author | Da Xing <qiyueliuhuo813@gmail.com> | 2018-11-18 20:10:17 +0800 |
|---|---|---|
| committer | Xin Li <delphij@google.com> | 2019-09-16 20:30:07 +0000 |
| commit | ecb568154a3403a4e52862606d65cb537eb4afc7 (patch) | |
| tree | 93040595d9d25c7fea7412f45f46a612dbd9a73d /libs/rs/rsg_ScriptJavaClass.cpp | |
| parent | 2a873c7628980444cfb2ae45311dc5181a2b2afd (diff) | |
Crash app on foreground service notification error.
On any notification error, the NMS silently cancels the notification,
including foreground service notifications. Thus, an app could pass in a
garbage notification deliberately and start a foreground service silently.
This patch resolved this issue by judging the notification's flag, and if
it is a foreground notification, still crash the app as previous platforms,
and if it is a normal notification, don't crash the app.
Background: In 3ad4cdd1, which was merged into Android 9 release, the crash
behaviour is removed. But it is an important rule that foreground services
guaranteed to show an ongoing notification.
Test: Run the sample apk provided in the issue, it's main thread received
a RemoteServiceException: Bad notification posted from package...
as intended behaviour.
Fixes: 118612296
Merged-In: I36ea0137ca6978ff401f64dccacb6f2edcadd7db
Change-Id: I36ea0137ca6978ff401f64dccacb6f2edcadd7db
Signed-off-by: Da Xing <qiyueliuhuo813@gmail.com>
(cherry picked from commit b740ed72b93e4671ced674456b2eaac26fda5ab9)
Diffstat (limited to 'libs/rs/rsg_ScriptJavaClass.cpp')
0 files changed, 0 insertions, 0 deletions