summaryrefslogtreecommitdiff
path: root/libs/hwui
diff options
context:
space:
mode:
authorLeon Scroggins <scroggo@google.com>2020-07-23 13:56:41 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-07-23 13:56:41 +0000
commit53ee2070ed3e8357b6546df3e1b766b2fb8a848e (patch)
tree4fa309b37a9df03b392513fcc7c6e83c590e2d83 /libs/hwui
parentc2bfd3c51b4a3122c388b26cf3a53d4d0394fc27 (diff)
parenta97e560c61cc85ff1c5b27a46e790d815d56b0f1 (diff)
Merge "Update graphics language to comply with Android’s inclusive language guidance" am: da4dc882af am: a97e560c61
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1370379 Change-Id: I5d853a84c0fe1550d86d0f948f76e532af42e073
Diffstat (limited to 'libs/hwui')
-rw-r--r--libs/hwui/hwui/Bitmap.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/libs/hwui/hwui/Bitmap.cpp b/libs/hwui/hwui/Bitmap.cpp
index 56d951cdb338..60ef4371d38d 100644
--- a/libs/hwui/hwui/Bitmap.cpp
+++ b/libs/hwui/hwui/Bitmap.cpp
@@ -217,11 +217,8 @@ static SkImageInfo validateAlpha(const SkImageInfo& info) {
void Bitmap::reconfigure(const SkImageInfo& newInfo, size_t rowBytes) {
mInfo = validateAlpha(newInfo);
- // Dirty hack is dirty
- // TODO: Figure something out here, Skia's current design makes this
- // really hard to work with. Skia really, really wants immutable objects,
- // but with the nested-ref-count hackery going on that's just not
- // feasible without going insane trying to figure it out
+ // TODO: Skia intends for SkPixelRef to be immutable, but this method
+ // modifies it. Find another way to support reusing the same pixel memory.
this->android_only_reset(mInfo.width(), mInfo.height(), rowBytes);
}