diff options
author | Chih-Hung Hsieh <chh@google.com> | 2016-07-21 11:23:06 -0700 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2016-07-21 16:24:06 -0700 |
commit | faecb78a6b11c780db47bc940ca7662899ab5d5e (patch) | |
tree | b1ccd5cd96537fb8aac5f3ee7ddd4ef86809df1e /libs/hwui/thread | |
parent | ed6625d9074a1de1515c97faf201a91fbb3abb27 (diff) |
Fix google-explicit-constructor warnings in frameworks/base
* Add explicit keyword to conversion constructors.
* Add NOLINT to implicit conversion constructors.
Bug: 28341362
Test: build with clang-tidy
Change-Id: Ie4d37072ab57d1662d18db4de1c8577247f43337
Diffstat (limited to 'libs/hwui/thread')
-rw-r--r-- | libs/hwui/thread/Barrier.h | 2 | ||||
-rw-r--r-- | libs/hwui/thread/Future.h | 2 | ||||
-rw-r--r-- | libs/hwui/thread/Signal.h | 2 | ||||
-rw-r--r-- | libs/hwui/thread/TaskManager.h | 2 | ||||
-rw-r--r-- | libs/hwui/thread/TaskProcessor.h | 2 |
5 files changed, 5 insertions, 5 deletions
diff --git a/libs/hwui/thread/Barrier.h b/libs/hwui/thread/Barrier.h index 6cb23e54943b..bf107042c5cf 100644 --- a/libs/hwui/thread/Barrier.h +++ b/libs/hwui/thread/Barrier.h @@ -24,7 +24,7 @@ namespace uirenderer { class Barrier { public: - Barrier(Condition::WakeUpType type = Condition::WAKE_UP_ALL) : mType(type), mOpened(false) { } + explicit Barrier(Condition::WakeUpType type = Condition::WAKE_UP_ALL) : mType(type), mOpened(false) { } ~Barrier() { } void open() { diff --git a/libs/hwui/thread/Future.h b/libs/hwui/thread/Future.h index a3ff3bcc3698..177eebd9b85f 100644 --- a/libs/hwui/thread/Future.h +++ b/libs/hwui/thread/Future.h @@ -27,7 +27,7 @@ namespace uirenderer { template<typename T> class Future: public LightRefBase<Future<T> > { public: - Future(Condition::WakeUpType type = Condition::WAKE_UP_ONE): mBarrier(type), mResult() { } + explicit Future(Condition::WakeUpType type = Condition::WAKE_UP_ONE): mBarrier(type), mResult() { } ~Future() { } /** diff --git a/libs/hwui/thread/Signal.h b/libs/hwui/thread/Signal.h index d4cfeeb29c17..93e6f4c27535 100644 --- a/libs/hwui/thread/Signal.h +++ b/libs/hwui/thread/Signal.h @@ -26,7 +26,7 @@ namespace uirenderer { class Signal { public: - Signal(Condition::WakeUpType type = Condition::WAKE_UP_ALL) : mType(type), mSignaled(false) { } + explicit Signal(Condition::WakeUpType type = Condition::WAKE_UP_ALL) : mType(type), mSignaled(false) { } ~Signal() { } void signal() { diff --git a/libs/hwui/thread/TaskManager.h b/libs/hwui/thread/TaskManager.h index 10e8b9e0bead..4d3b8f07b548 100644 --- a/libs/hwui/thread/TaskManager.h +++ b/libs/hwui/thread/TaskManager.h @@ -77,7 +77,7 @@ private: class WorkerThread: public Thread { public: - WorkerThread(const String8 name): mSignal(Condition::WAKE_UP_ONE), mName(name) { } + explicit WorkerThread(const String8 name): mSignal(Condition::WAKE_UP_ONE), mName(name) { } bool addTask(TaskWrapper task); size_t getTaskCount() const; diff --git a/libs/hwui/thread/TaskProcessor.h b/libs/hwui/thread/TaskProcessor.h index 82538e9c7342..58674505c457 100644 --- a/libs/hwui/thread/TaskProcessor.h +++ b/libs/hwui/thread/TaskProcessor.h @@ -36,7 +36,7 @@ public: template<typename T> class TaskProcessor: public TaskProcessorBase { public: - TaskProcessor(TaskManager* manager): mManager(manager) { } + explicit TaskProcessor(TaskManager* manager): mManager(manager) { } virtual ~TaskProcessor() { } void add(const sp<Task<T> >& task) { |