summaryrefslogtreecommitdiff
path: root/libs/hwui/service/GraphicsStatsService.cpp
diff options
context:
space:
mode:
authorliulvping <liulvping@xiaomi.com>2018-12-20 20:34:56 +0800
committerlvping liu <liulvping@xiaomi.com>2019-01-02 10:54:57 +0000
commit4832438c3a31a5316f8b33ccfbe961accd946e2e (patch)
tree2eb0fb5baa39fd9e1a2d0a6b1d65a448c50358c0 /libs/hwui/service/GraphicsStatsService.cpp
parent99f6957f2e42caeea209d2069174cab24c347a95 (diff)
fix mmap leak of graphicsstats service
Test: repeat dumpsys graphicsstats and check process maps Change-Id: Iae2baa7eb7761aefb867644edfaaf8dbe2132c7b Signed-off-by: liulvping <liulvping@xiaomi.com>
Diffstat (limited to 'libs/hwui/service/GraphicsStatsService.cpp')
-rw-r--r--libs/hwui/service/GraphicsStatsService.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/libs/hwui/service/GraphicsStatsService.cpp b/libs/hwui/service/GraphicsStatsService.cpp
index 3d50d2d7e59c..29e4256e2ab7 100644
--- a/libs/hwui/service/GraphicsStatsService.cpp
+++ b/libs/hwui/service/GraphicsStatsService.cpp
@@ -139,6 +139,7 @@ bool GraphicsStatsService::parseFromFile(const std::string& path,
uint32_t file_version = *reinterpret_cast<uint32_t*>(addr);
if (file_version != sCurrentFileVersion) {
ALOGW("file_version mismatch! expected %d got %d", sCurrentFileVersion, file_version);
+ munmap(addr, sb.st_size);
return false;
}
@@ -150,6 +151,7 @@ bool GraphicsStatsService::parseFromFile(const std::string& path,
ALOGW("Parse failed on '%s' error='%s'", path.c_str(),
output->InitializationErrorString().c_str());
}
+ munmap(addr, sb.st_size);
return success;
}