summaryrefslogtreecommitdiff
path: root/libs/hwui/pipeline/skia/SkiaPipeline.cpp
diff options
context:
space:
mode:
authorNathaniel Nifong <nifong@google.com>2020-01-17 15:32:17 -0500
committerNathaniel Nifong <nifong@google.com>2020-01-17 20:53:31 +0000
commit89a5dc514e69bc5db205910f0106418a0a558c85 (patch)
tree204ae6b1e663674f9e49fab35681f7604091e57e /libs/hwui/pipeline/skia/SkiaPipeline.cpp
parentf85aaad61579a9845a5d24c6f1cd63f043f74385 (diff)
Do not clip draw commands during recording of SKP files
Test: Confirmed drawing is unaffected on pixel 3, confirmed all commands are recorded. Change-Id: Ib543730c321f5082d9a2331241873f9b2e8289c8 Bug: skia:9758
Diffstat (limited to 'libs/hwui/pipeline/skia/SkiaPipeline.cpp')
-rw-r--r--libs/hwui/pipeline/skia/SkiaPipeline.cpp12
1 files changed, 9 insertions, 3 deletions
diff --git a/libs/hwui/pipeline/skia/SkiaPipeline.cpp b/libs/hwui/pipeline/skia/SkiaPipeline.cpp
index 35a885f46919..b940cff04713 100644
--- a/libs/hwui/pipeline/skia/SkiaPipeline.cpp
+++ b/libs/hwui/pipeline/skia/SkiaPipeline.cpp
@@ -458,9 +458,15 @@ void SkiaPipeline::renderFrameImpl(const SkRect& clip,
const SkMatrix& preTransform) {
SkAutoCanvasRestore saver(canvas, true);
auto clipRestriction = preTransform.mapRect(clip).roundOut();
- canvas->androidFramework_setDeviceClipRestriction(clipRestriction);
- canvas->drawAnnotation(SkRect::Make(clipRestriction), "AndroidDeviceClipRestriction",
- nullptr);
+ if (CC_UNLIKELY(mCaptureMode == CaptureMode::SingleFrameSKP
+ || mCaptureMode == CaptureMode::MultiFrameSKP)) {
+ canvas->drawAnnotation(SkRect::Make(clipRestriction), "AndroidDeviceClipRestriction",
+ nullptr);
+ } else {
+ // clip drawing to dirty region only when not recording SKP files (which should contain all
+ // draw ops on every frame)
+ canvas->androidFramework_setDeviceClipRestriction(clipRestriction);
+ }
canvas->concat(preTransform);
// STOPSHIP: Revert, temporary workaround to clear always F16 frame buffer for b/74976293