diff options
| author | Pirama Arumuga Nainar <pirama@google.com> | 2019-02-07 13:24:24 -0800 |
|---|---|---|
| committer | Pirama Arumuga Nainar <pirama@google.com> | 2019-02-07 13:24:24 -0800 |
| commit | 459afe96d13876c1fbeacb1f0d4bd0eddb7342e0 (patch) | |
| tree | 087bc16ae4236e3bfd67e0c0af7475fb96a4849a /libs/hwui/FrameMetricsObserver.h | |
| parent | 21b38267fa281b27a8ecac799a4f941f5b9519b8 (diff) | |
Mark FrameMetricsObserver::notify() as pure virtual
Bug: http://b/116873221
If not, Clang assumes that the TU which defines this function will
contain the vtable for the class as well. Since there's no out-of-line
definition of this funciton, no TU ends up with the vtable.
This causes a problem with coverage builds, which are built with -O0,
where calls don't get inlined, thereby requiring a definition of the
vtable. For non -O0 builds, the vtable is not required since the
virtual calls get inlined/optimized-out.
Test: Build with and without -O0.
Change-Id: I60a5cefcd1c327f1e00785fedbb2163c682b33d1
Diffstat (limited to 'libs/hwui/FrameMetricsObserver.h')
| -rw-r--r-- | libs/hwui/FrameMetricsObserver.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/hwui/FrameMetricsObserver.h b/libs/hwui/FrameMetricsObserver.h index ba72e937095f..0b9ae5cb4b7b 100644 --- a/libs/hwui/FrameMetricsObserver.h +++ b/libs/hwui/FrameMetricsObserver.h @@ -23,7 +23,7 @@ namespace uirenderer { class FrameMetricsObserver : public VirtualLightRefBase { public: - virtual void notify(const int64_t* buffer); + virtual void notify(const int64_t* buffer) = 0; }; }; // namespace uirenderer |