diff options
| author | John Reck <jreck@google.com> | 2017-01-25 10:58:30 -0800 |
|---|---|---|
| committer | John Reck <jreck@google.com> | 2017-01-25 12:24:40 -0800 |
| commit | 2de950d5a8b47c7b4648ada1b1260ce4b7342798 (patch) | |
| tree | d374208f819ffd994c51f258b9732b231ba7d9a1 /libs/hwui/DisplayList.h | |
| parent | df7f28352029766755a4187786db12351ce843c6 (diff) | |
Overhaul RenderNode's DisplayList management
* Move mValid to native
* Have destroyHardwareResources destroy everything
* Remove flaky mParentCount checks in setStaging
* All tree updates have an internal observer to
ensure onRemovedFromTree() is a reliable signal
* onRemovedFromTree() immediately releases resources
to avoid displaylist "leaks"
Test: Unit tests for validity added & pass, manually
verified that b/34072929 doesn't repro
Bug: 34072929
Change-Id: I856534b4ed1b7f009fc4b7cd13209b97fa42a71c
Diffstat (limited to 'libs/hwui/DisplayList.h')
| -rw-r--r-- | libs/hwui/DisplayList.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libs/hwui/DisplayList.h b/libs/hwui/DisplayList.h index cab092ffc34c..ef0fd31fdfdf 100644 --- a/libs/hwui/DisplayList.h +++ b/libs/hwui/DisplayList.h @@ -125,8 +125,8 @@ public: virtual void syncContents(); virtual void updateChildren(std::function<void(RenderNode*)> updateFn); - virtual bool prepareListAndChildren(TreeInfo& info, bool functorsNeedLayer, - std::function<void(RenderNode*, TreeInfo&, bool)> childFn); + virtual bool prepareListAndChildren(TreeObserver& observer, TreeInfo& info, bool functorsNeedLayer, + std::function<void(RenderNode*, TreeObserver&, TreeInfo&, bool)> childFn); protected: // allocator into which all ops and LsaVector arrays allocated |