diff options
| author | Nick Desaulniers <ndesaulniers@google.com> | 2019-10-10 13:11:23 -0700 |
|---|---|---|
| committer | Nick Desaulniers <ndesaulniers@google.com> | 2019-10-10 20:22:44 +0000 |
| commit | 19ae5f9ac9ce7a76003f68f9852a852d369a10b1 (patch) | |
| tree | 2927c1074973fd2eed877954c94d1ba0bce3b257 /libs/hwui/DamageAccumulator.h | |
| parent | 58664e8a7ce9e45924fff607c1763660233200e9 (diff) | |
[frameworks][base][hwui] fix -Wimplicit-int-float-conversion
DIRTY_MAX cannot be represented precisely in an IEEE 754 single
precision float. Calls to DamageAccumulator::dirty() that pass
DIRTY_MAX thus result in an implicit cast that results in imprecision.
Add one to the DIRTY_MAX constant so that its value can be precisely
representing in a single precision float.
Alternatively, we can accept the imprecision via explicit casts in
multiple call sites.
Bug: 139945549
Test: mm
Change-Id: I38b2942f976ad05af2d0e45d1a9fe4214e759a02
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Diffstat (limited to 'libs/hwui/DamageAccumulator.h')
| -rw-r--r-- | libs/hwui/DamageAccumulator.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/hwui/DamageAccumulator.h b/libs/hwui/DamageAccumulator.h index 7d0b6877a71a..030a20f31c42 100644 --- a/libs/hwui/DamageAccumulator.h +++ b/libs/hwui/DamageAccumulator.h @@ -27,7 +27,7 @@ // Smaller than INT_MIN/INT_MAX because we offset these values // and thus don't want to be adding offsets to INT_MAX, that's bad #define DIRTY_MIN (-0x7ffffff - 1) -#define DIRTY_MAX (0x7ffffff) +#define DIRTY_MAX (0x8000000) namespace android { namespace uirenderer { |