diff options
author | Adam Lesinski <adamlesinski@google.com> | 2016-10-03 20:07:37 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2016-10-03 20:07:37 +0000 |
commit | 126e022095376e5433be6e18d2cfd19e2ef29446 (patch) | |
tree | a828c4ae5f98c98c8bb7d86705d6687d0bc8d010 /libs/androidfw/AssetManager.cpp | |
parent | 01614e4e7f299347ad01002e3ec92def00f41d8a (diff) | |
parent | 49921f2c05cff6d4526b5b30f7b8e2d8bbabc069 (diff) |
Merge "[AssetManager]:Fix thread race caused double free issue."
Diffstat (limited to 'libs/androidfw/AssetManager.cpp')
-rw-r--r-- | libs/androidfw/AssetManager.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libs/androidfw/AssetManager.cpp b/libs/androidfw/AssetManager.cpp index f50cff4387d2..8ea25d60cc89 100644 --- a/libs/androidfw/AssetManager.cpp +++ b/libs/androidfw/AssetManager.cpp @@ -1892,6 +1892,7 @@ ZipFileRO* AssetManager::SharedZip::getZip() Asset* AssetManager::SharedZip::getResourceTableAsset() { + AutoMutex _l(gLock); ALOGV("Getting from SharedZip %p resource asset %p\n", this, mResourceTableAsset); return mResourceTableAsset; } @@ -1901,10 +1902,10 @@ Asset* AssetManager::SharedZip::setResourceTableAsset(Asset* asset) { AutoMutex _l(gLock); if (mResourceTableAsset == NULL) { - mResourceTableAsset = asset; // This is not thread safe the first time it is called, so // do it here with the global lock held. asset->getBuffer(true); + mResourceTableAsset = asset; return asset; } } |