summaryrefslogtreecommitdiff
path: root/docs/html/sdk/api_diff/21/changes
diff options
context:
space:
mode:
authorYohei Yukawa <yukawa@google.com>2015-06-16 00:29:28 -0700
committerYohei Yukawa <yukawa@google.com>2015-06-16 00:29:28 -0700
commitf05ce728f95ce2a294981ee94167d42a35f50f8c (patch)
treed27d036d129df7d18aab4c401dec1183a840e438 /docs/html/sdk/api_diff/21/changes
parent100e1c9235720ac020a20009da8b85f64efd4c11 (diff)
Fix a reference leak in SpellCheckerSessionListenerImpl.
The primary goal of this CL is to address a reference leak in SpellCheckerSession.SpellCheckerSessionListenerImpl if the SpellCheckerSession is closed too early. Here is the minimum repro code. TextServicesManager tsm = (TextServicesManager) getSystemService(Context.TEXT_SERVICES_MANAGER_SERVICE); SpellCheckerSession session = tsm.newSpellCheckerSession(, Locale.ENGLISH, listener, false); session.close(); In order to make the state management reliable and easier to debug, this CL replaces SpellCheckerSessionListenerImpl#mOpened with an explicit state number so that we can tell three different "not open" cases: 1) not connected yet and not closed yet, 2) closed before establishing connection, and 3) closed after establishing connection. Bug: 21319642 Change-Id: Ifd05565ac0c057c46ec88a3fb9094c04934041d7
Diffstat (limited to 'docs/html/sdk/api_diff/21/changes')
0 files changed, 0 insertions, 0 deletions