diff options
| author | Ruchir Rastogi <ruchirr@google.com> | 2020-04-06 14:10:04 -0700 |
|---|---|---|
| committer | Ruchir Rastogi <ruchirr@google.com> | 2020-04-06 14:10:04 -0700 |
| commit | 1d4fdcb6def9602ea8ed523e7fa1930502e692db (patch) | |
| tree | 1a50f620893a1d24db320faef99d3cb229879377 /cmds/statsd/src/shell/ShellSubscriber.cpp | |
| parent | 17849976da46cc90a50d5498109980e31e1900bb (diff) | |
Remove obsolete/infeasible TODOs
(a) Clean up LogEvent::parseBuffer - having those variables be member
variables really helps with code readability.
(b) Don't hold locks when writing to pipe within ShellSubscriber -
ag/150969574 describes why holding a lock is necessary.
Test: m
Bug: 150312423 (allows this bug to be marked as obsolete)
Change-Id: I4903de1dc87a552932b70e5975a7cde91df05b3b
Diffstat (limited to 'cmds/statsd/src/shell/ShellSubscriber.cpp')
| -rw-r--r-- | cmds/statsd/src/shell/ShellSubscriber.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cmds/statsd/src/shell/ShellSubscriber.cpp b/cmds/statsd/src/shell/ShellSubscriber.cpp index 1cee4d9babdc..bed836a1bd90 100644 --- a/cmds/statsd/src/shell/ShellSubscriber.cpp +++ b/cmds/statsd/src/shell/ShellSubscriber.cpp @@ -152,7 +152,6 @@ void ShellSubscriber::startPull(int64_t myToken) { mPullerMgr->Pull(pullInfo.mPullerMatcher.atom_id(), uids, &data); VLOG("pulled %zu atoms with id %d", data.size(), pullInfo.mPullerMatcher.atom_id()); - // TODO(b/150969574): Don't write to a pipe while holding a lock. if (!writePulledAtomsLocked(data, pullInfo.mPullerMatcher)) { mSubscriptionInfo->mClientAlive = false; mSubscriptionShouldEnd.notify_one(); |