diff options
| author | Tej Singh <singhtejinder@google.com> | 2018-04-10 17:24:50 -0700 |
|---|---|---|
| committer | Tej Singh <singhtejinder@google.com> | 2018-04-16 15:04:28 -0700 |
| commit | dd83d703712bfa004a6bb71ddd19780b2d0b79ba (patch) | |
| tree | 0958729aa8bbe5c071f2e8831e8596775aebc804 /cmds/statsd/src/StatsService.cpp | |
| parent | 5000367d38154428f9e57dbb0097cbaca7b7c0c4 (diff) | |
Enforce dump permission in stats service
Enforces the dump permission in stats service and fixes a typo in an
enum name.
Bug: b/77723108
Test: adb shell dumpsys stats as root and not root
Test: build success on marlin (and cts build success)
Change-Id: I131f97fe4fd370d50bc4ad369377f6adcca5f6ae
Diffstat (limited to 'cmds/statsd/src/StatsService.cpp')
| -rw-r--r-- | cmds/statsd/src/StatsService.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cmds/statsd/src/StatsService.cpp b/cmds/statsd/src/StatsService.cpp index f7cc00ced679..6652db609f2f 100644 --- a/cmds/statsd/src/StatsService.cpp +++ b/cmds/statsd/src/StatsService.cpp @@ -172,6 +172,9 @@ status_t StatsService::onTransact(uint32_t code, const Parcel& data, Parcel* rep * Write debugging data about statsd. */ status_t StatsService::dump(int fd, const Vector<String16>& args) { + if (!checkCallingPermission(String16(kPermissionDump))) { + return PERMISSION_DENIED; + } FILE* out = fdopen(fd, "w"); if (out == NULL) { return NO_MEMORY; // the fd is already open |