diff options
author | Yi Jin <jinyithu@google.com> | 2018-01-24 21:48:36 -0800 |
---|---|---|
committer | Yi Jin <jinyithu@google.com> | 2018-02-13 18:05:32 -0800 |
commit | 51d4c54eba8dd613dd0550c6633a747b53e0ce0a (patch) | |
tree | daaac252c97315bb5870eb618b2aa84d1af62ea9 /cmds/incident_helper/src | |
parent | 85a6db68f1860bbaacc1cc21e29c4f61aabe0abb (diff) |
Make the platform proto naming consistent, Part 1
Change proto names in incident_helper
Bug: 72474563
Test: atest incident_helper_test
Change-Id: Ia416ef9726a19d247e62d7de1028874408ec53f1
Diffstat (limited to 'cmds/incident_helper/src')
6 files changed, 57 insertions, 53 deletions
diff --git a/cmds/incident_helper/src/parsers/CpuFreqParser.cpp b/cmds/incident_helper/src/parsers/CpuFreqParser.cpp index 02f1ce7cc0fc..fde17bd97a7f 100644 --- a/cmds/incident_helper/src/parsers/CpuFreqParser.cpp +++ b/cmds/incident_helper/src/parsers/CpuFreqParser.cpp @@ -62,15 +62,15 @@ CpuFreqParser::Parse(const int in, const int out) const ProtoOutputStream proto; long jiffyHz = sysconf(_SC_CLK_TCK); - proto.write(CpuFreq::JIFFY_HZ, (int)jiffyHz); + proto.write(CpuFreqProto::JIFFY_HZ, (int)jiffyHz); for (int i=0; i<numCpus; i++) { - long long token = proto.start(CpuFreq::CPU_FREQS); - proto.write(CpuFreqStats::CPU_NAME, header[i+1]); + long long token = proto.start(CpuFreqProto::CPU_FREQS); + proto.write(CpuFreqProto::Stats::CPU_NAME, header[i+1]); for (vector<pair<int, long long>>::iterator it = cpucores[i].begin(); it != cpucores[i].end(); it++) { - long long stateToken = proto.start(CpuFreqStats::TIMES); - proto.write(CpuFreqStats::TimeInState::STATE_KHZ, it->first); - proto.write(CpuFreqStats::TimeInState::TIME_JIFFY, it->second); + long long stateToken = proto.start(CpuFreqProto::Stats::TIMES); + proto.write(CpuFreqProto::Stats::TimeInState::STATE_KHZ, it->first); + proto.write(CpuFreqProto::Stats::TimeInState::TIME_JIFFY, it->second); proto.end(stateToken); } proto.end(token); diff --git a/cmds/incident_helper/src/parsers/CpuInfoParser.cpp b/cmds/incident_helper/src/parsers/CpuInfoParser.cpp index d73de54d8c5d..b2b431c62866 100644 --- a/cmds/incident_helper/src/parsers/CpuInfoParser.cpp +++ b/cmds/incident_helper/src/parsers/CpuInfoParser.cpp @@ -54,11 +54,11 @@ CpuInfoParser::Parse(const int in, const int out) const bool nextToUsage = false; ProtoOutputStream proto; - Table table(CpuInfo::Task::_FIELD_NAMES, CpuInfo::Task::_FIELD_IDS, CpuInfo::Task::_FIELD_COUNT); - table.addEnumTypeMap("s", CpuInfo::Task::_ENUM_STATUS_NAMES, - CpuInfo::Task::_ENUM_STATUS_VALUES, CpuInfo::Task::_ENUM_STATUS_COUNT); - table.addEnumTypeMap("pcy", CpuInfo::Task::_ENUM_POLICY_NAMES, - CpuInfo::Task::_ENUM_POLICY_VALUES, CpuInfo::Task::_ENUM_POLICY_COUNT); + Table table(CpuInfoProto::Task::_FIELD_NAMES, CpuInfoProto::Task::_FIELD_IDS, CpuInfoProto::Task::_FIELD_COUNT); + table.addEnumTypeMap("s", CpuInfoProto::Task::_ENUM_STATUS_NAMES, + CpuInfoProto::Task::_ENUM_STATUS_VALUES, CpuInfoProto::Task::_ENUM_STATUS_COUNT); + table.addEnumTypeMap("pcy", CpuInfoProto::Task::_ENUM_POLICY_NAMES, + CpuInfoProto::Task::_ENUM_POLICY_VALUES, CpuInfoProto::Task::_ENUM_POLICY_COUNT); // parse line by line while (reader.readLine(&line)) { @@ -67,33 +67,33 @@ CpuInfoParser::Parse(const int in, const int out) const nline++; if (stripPrefix(&line, "Tasks:")) { - writeSuffixLine(&proto, CpuInfo::TASK_STATS, line, COMMA_DELIMITER, - CpuInfo::TaskStats::_FIELD_COUNT, - CpuInfo::TaskStats::_FIELD_NAMES, - CpuInfo::TaskStats::_FIELD_IDS); + writeSuffixLine(&proto, CpuInfoProto::TASK_STATS, line, COMMA_DELIMITER, + CpuInfoProto::TaskStats::_FIELD_COUNT, + CpuInfoProto::TaskStats::_FIELD_NAMES, + CpuInfoProto::TaskStats::_FIELD_IDS); continue; } if (stripPrefix(&line, "Mem:")) { - writeSuffixLine(&proto, CpuInfo::MEM, line, COMMA_DELIMITER, - CpuInfo::MemStats::_FIELD_COUNT, - CpuInfo::MemStats::_FIELD_NAMES, - CpuInfo::MemStats::_FIELD_IDS); + writeSuffixLine(&proto, CpuInfoProto::MEM, line, COMMA_DELIMITER, + CpuInfoProto::MemStats::_FIELD_COUNT, + CpuInfoProto::MemStats::_FIELD_NAMES, + CpuInfoProto::MemStats::_FIELD_IDS); continue; } if (stripPrefix(&line, "Swap:")) { - writeSuffixLine(&proto, CpuInfo::SWAP, line, COMMA_DELIMITER, - CpuInfo::MemStats::_FIELD_COUNT, - CpuInfo::MemStats::_FIELD_NAMES, - CpuInfo::MemStats::_FIELD_IDS); + writeSuffixLine(&proto, CpuInfoProto::SWAP, line, COMMA_DELIMITER, + CpuInfoProto::MemStats::_FIELD_COUNT, + CpuInfoProto::MemStats::_FIELD_NAMES, + CpuInfoProto::MemStats::_FIELD_IDS); nextToSwap = true; continue; } if (nextToSwap) { - writeSuffixLine(&proto, CpuInfo::CPU_USAGE, line, DEFAULT_WHITESPACE, - CpuInfo::CpuUsage::_FIELD_COUNT, - CpuInfo::CpuUsage::_FIELD_NAMES, - CpuInfo::CpuUsage::_FIELD_IDS); + writeSuffixLine(&proto, CpuInfoProto::CPU_USAGE, line, DEFAULT_WHITESPACE, + CpuInfoProto::CpuUsage::_FIELD_COUNT, + CpuInfoProto::CpuUsage::_FIELD_NAMES, + CpuInfoProto::CpuUsage::_FIELD_IDS); nextToUsage = true; nextToSwap = false; continue; @@ -138,7 +138,7 @@ CpuInfoParser::Parse(const int in, const int out) const continue; } - long long token = proto.start(CpuInfo::TASKS); + long long token = proto.start(CpuInfoProto::TASKS); for (int i=0; i<(int)record.size(); i++) { if (!table.insertField(&proto, header[i], record[i])) { fprintf(stderr, "[%s]Line %d fails to insert field %s with value %s\n", diff --git a/cmds/incident_helper/src/parsers/KernelWakesParser.cpp b/cmds/incident_helper/src/parsers/KernelWakesParser.cpp index cae51abbe57f..28816ea75a75 100644 --- a/cmds/incident_helper/src/parsers/KernelWakesParser.cpp +++ b/cmds/incident_helper/src/parsers/KernelWakesParser.cpp @@ -33,7 +33,9 @@ KernelWakesParser::Parse(const int in, const int out) const int nline = 0; ProtoOutputStream proto; - Table table(WakeupSourceProto::_FIELD_NAMES, WakeupSourceProto::_FIELD_IDS, WakeupSourceProto::_FIELD_COUNT); + Table table(KernelWakeSourcesProto::WakeupSource::_FIELD_NAMES, + KernelWakeSourcesProto::WakeupSource::_FIELD_IDS, + KernelWakeSourcesProto::WakeupSource::_FIELD_COUNT); // parse line by line while (reader.readLine(&line)) { @@ -57,7 +59,7 @@ KernelWakesParser::Parse(const int in, const int out) const continue; } - long long token = proto.start(KernelWakeSources::WAKEUP_SOURCES); + long long token = proto.start(KernelWakeSourcesProto::WAKEUP_SOURCES); for (int i=0; i<(int)record.size(); i++) { if (!table.insertField(&proto, header[i], record[i])) { fprintf(stderr, "[%s]Line %d has bad value %s of %s\n", diff --git a/cmds/incident_helper/src/parsers/PageTypeInfoParser.cpp b/cmds/incident_helper/src/parsers/PageTypeInfoParser.cpp index f1b93ff9ec41..45a0e7b459d2 100644 --- a/cmds/incident_helper/src/parsers/PageTypeInfoParser.cpp +++ b/cmds/incident_helper/src/parsers/PageTypeInfoParser.cpp @@ -33,7 +33,9 @@ PageTypeInfoParser::Parse(const int in, const int out) const header_t blockHeader; ProtoOutputStream proto; - Table table(BlockProto::_FIELD_NAMES, BlockProto::_FIELD_IDS, BlockProto::_FIELD_COUNT); + Table table(PageTypeInfoProto::Block::_FIELD_NAMES, + PageTypeInfoProto::Block::_FIELD_IDS, + PageTypeInfoProto::Block::_FIELD_COUNT); while (reader.readLine(&line)) { if (line.empty()) { @@ -44,11 +46,11 @@ PageTypeInfoParser::Parse(const int in, const int out) const if (stripPrefix(&line, "Page block order:")) { pageBlockOrder = toInt(line); - proto.write(PageTypeInfo::PAGE_BLOCK_ORDER, pageBlockOrder); + proto.write(PageTypeInfoProto::PAGE_BLOCK_ORDER, pageBlockOrder); continue; } if (stripPrefix(&line, "Pages per block:")) { - proto.write(PageTypeInfo::PAGES_PER_BLOCK, toInt(line)); + proto.write(PageTypeInfoProto::PAGES_PER_BLOCK, toInt(line)); continue; } if (stripPrefix(&line, "Free pages count per migrate type at order")) { @@ -62,14 +64,14 @@ PageTypeInfoParser::Parse(const int in, const int out) const record_t record = parseRecord(line, COMMA_DELIMITER); if (migrateTypeSession && record.size() == 3) { - long long token = proto.start(PageTypeInfo::MIGRATE_TYPES); + long long token = proto.start(PageTypeInfoProto::MIGRATE_TYPES); // expect part 0 starts with "Node" if (stripPrefix(&record[0], "Node")) { - proto.write(MigrateTypeProto::NODE, toInt(record[0])); + proto.write(PageTypeInfoProto::MigrateType::NODE, toInt(record[0])); } else return BAD_VALUE; // expect part 1 starts with "zone" if (stripPrefix(&record[1], "zone")) { - proto.write(MigrateTypeProto::ZONE, record[1]); + proto.write(PageTypeInfoProto::MigrateType::ZONE, record[1]); } else return BAD_VALUE; // expect part 2 starts with "type" if (stripPrefix(&record[2], "type")) { @@ -83,22 +85,22 @@ PageTypeInfoParser::Parse(const int in, const int out) const int pageCountsSize = pageBlockOrder + 2; if ((int)pageCounts.size() != pageCountsSize) return BAD_VALUE; - proto.write(MigrateTypeProto::TYPE, pageCounts[0]); + proto.write(PageTypeInfoProto::MigrateType::TYPE, pageCounts[0]); for (auto i=1; i<pageCountsSize; i++) { - proto.write(MigrateTypeProto::FREE_PAGES_COUNT, toInt(pageCounts[i])); + proto.write(PageTypeInfoProto::MigrateType::FREE_PAGES_COUNT, toInt(pageCounts[i])); } } else return BAD_VALUE; proto.end(token); } else if (!blockHeader.empty() && record.size() == 2) { - long long token = proto.start(PageTypeInfo::BLOCKS); + long long token = proto.start(PageTypeInfoProto::BLOCKS); if (stripPrefix(&record[0], "Node")) { - proto.write(BlockProto::NODE, toInt(record[0])); + proto.write(PageTypeInfoProto::Block::NODE, toInt(record[0])); } else return BAD_VALUE; if (stripPrefix(&record[1], "zone")) { record_t blockCounts = parseRecord(record[1]); - proto.write(BlockProto::ZONE, blockCounts[0]); + proto.write(PageTypeInfoProto::Block::ZONE, blockCounts[0]); for (size_t i=0; i<blockHeader.size(); i++) { if (!table.insertField(&proto, blockHeader[i], blockCounts[i+1])) { diff --git a/cmds/incident_helper/src/parsers/ProcrankParser.cpp b/cmds/incident_helper/src/parsers/ProcrankParser.cpp index a4eb0fdfd988..c1c458e69ddf 100644 --- a/cmds/incident_helper/src/parsers/ProcrankParser.cpp +++ b/cmds/incident_helper/src/parsers/ProcrankParser.cpp @@ -33,7 +33,7 @@ ProcrankParser::Parse(const int in, const int out) const int nline = 0; ProtoOutputStream proto; - Table table(ProcessProto::_FIELD_NAMES, ProcessProto::_FIELD_IDS, ProcessProto::_FIELD_COUNT); + Table table(ProcrankProto::Process::_FIELD_NAMES, ProcrankProto::Process::_FIELD_IDS, ProcrankProto::Process::_FIELD_COUNT); string zram, ram, total; // parse line by line @@ -66,7 +66,7 @@ ProcrankParser::Parse(const int in, const int out) const continue; } - long long token = proto.start(Procrank::PROCESSES); + long long token = proto.start(ProcrankProto::PROCESSES); for (int i=0; i<(int)record.size(); i++) { if (!table.insertField(&proto, header[i], record[i])) { fprintf(stderr, "[%s]Line %d has bad value %s of %s\n", @@ -77,23 +77,23 @@ ProcrankParser::Parse(const int in, const int out) const } // add summary - long long token = proto.start(Procrank::SUMMARY); + long long token = proto.start(ProcrankProto::SUMMARY); if (!total.empty()) { record = parseRecord(total); - long long token = proto.start(SummaryProto::TOTAL); + long long token = proto.start(ProcrankProto::Summary::TOTAL); for (int i=(int)record.size(); i>0; i--) { table.insertField(&proto, header[header.size() - i].c_str(), record[record.size() - i].c_str()); } proto.end(token); } if (!zram.empty()) { - long long token = proto.start(SummaryProto::ZRAM); - proto.write(ZramProto::RAW_TEXT, zram); + long long token = proto.start(ProcrankProto::Summary::ZRAM); + proto.write(ProcrankProto::Summary::Zram::RAW_TEXT, zram); proto.end(token); } if (!ram.empty()) { - long long token = proto.start(SummaryProto::RAM); - proto.write(RamProto::RAW_TEXT, ram); + long long token = proto.start(ProcrankProto::Summary::RAM); + proto.write(ProcrankProto::Summary::Ram::RAW_TEXT, ram); proto.end(token); } proto.end(token); diff --git a/cmds/incident_helper/src/parsers/PsParser.cpp b/cmds/incident_helper/src/parsers/PsParser.cpp index e9014cacfa0b..420775fb5f04 100644 --- a/cmds/incident_helper/src/parsers/PsParser.cpp +++ b/cmds/incident_helper/src/parsers/PsParser.cpp @@ -33,12 +33,12 @@ status_t PsParser::Parse(const int in, const int out) const { int diff = 0; ProtoOutputStream proto; - Table table(PsDumpProto::Process::_FIELD_NAMES, PsDumpProto::Process::_FIELD_IDS, PsDumpProto::Process::_FIELD_COUNT); + Table table(PsProto::Process::_FIELD_NAMES, PsProto::Process::_FIELD_IDS, PsProto::Process::_FIELD_COUNT); const char* pcyNames[] = { "fg", "bg", "ta" }; - const int pcyValues[] = {PsDumpProto::Process::POLICY_FG, PsDumpProto::Process::POLICY_BG, PsDumpProto::Process::POLICY_TA}; + const int pcyValues[] = {PsProto::Process::POLICY_FG, PsProto::Process::POLICY_BG, PsProto::Process::POLICY_TA}; table.addEnumTypeMap("pcy", pcyNames, pcyValues, 3); const char* sNames[] = { "D", "R", "S", "T", "t", "X", "Z" }; - const int sValues[] = {PsDumpProto::Process::STATE_D, PsDumpProto::Process::STATE_R, PsDumpProto::Process::STATE_S, PsDumpProto::Process::STATE_T, PsDumpProto::Process::STATE_TRACING, PsDumpProto::Process::STATE_X, PsDumpProto::Process::STATE_Z}; + const int sValues[] = {PsProto::Process::STATE_D, PsProto::Process::STATE_R, PsProto::Process::STATE_S, PsProto::Process::STATE_T, PsProto::Process::STATE_TRACING, PsProto::Process::STATE_X, PsProto::Process::STATE_Z}; table.addEnumTypeMap("s", sNames, sValues, 7); // Parse line by line @@ -71,7 +71,7 @@ status_t PsParser::Parse(const int in, const int out) const { continue; } - long long token = proto.start(PsDumpProto::PROCESSES); + long long token = proto.start(PsProto::PROCESSES); for (int i=0; i<(int)record.size(); i++) { if (!table.insertField(&proto, header[i], record[i])) { fprintf(stderr, "[%s]Line %d has bad value %s of %s\n", |