summaryrefslogtreecommitdiff
path: root/cmds/am/src
diff options
context:
space:
mode:
authorNikita Ioffe <ioffe@google.com>2020-06-08 22:24:06 +0100
committerNikita Ioffe <ioffe@google.com>2020-06-11 19:51:54 +0100
commitac095e5a1dc4b76af6b82dd246ed54d0fca888fb (patch)
tree861bc31fdb4f1f3f61cf0885682488c854b12b53 /cmds/am/src
parent95e41f279ddb8cea10fc650d08a4cca2efb509a3 (diff)
Start OP_NO_ISOLATED_STORAGE on `am instrument --no-isolated-storage`
This provides a signal for MediaProvider to whitelist access for full external storage access. Here is an overview of how the flow looks like: 1. When app is started within instrumentation with --no-isolated-storage flag, ActivityManagerService will grant OP_NO_ISOLATED_STORAGE to that package. 2. MediaProvider will note the OP_NO_ISOLATED_STORAGE app op as fallback in case app doesn't have MANAGE_EXTERNAL_STORAGE permissions. 3. When instrumentation finishes, ActivityManagerService will change mode of OP_NO_ISOLATED_STORAGE app op to MODE_ERRORED. Test: atest ExternalStorageHostTest Bug: 149894531 Change-Id: I51cd87e5e887b887fd8ac7a1a7ffff208266ffa8
Diffstat (limited to 'cmds/am/src')
-rw-r--r--cmds/am/src/com/android/commands/am/Instrument.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/cmds/am/src/com/android/commands/am/Instrument.java b/cmds/am/src/com/android/commands/am/Instrument.java
index 2adbc1f6e1ae..7c30c8b1e1dd 100644
--- a/cmds/am/src/com/android/commands/am/Instrument.java
+++ b/cmds/am/src/com/android/commands/am/Instrument.java
@@ -17,8 +17,8 @@
package com.android.commands.am;
import static android.app.ActivityManager.INSTR_FLAG_DISABLE_HIDDEN_API_CHECKS;
+import static android.app.ActivityManager.INSTR_FLAG_DISABLE_ISOLATED_STORAGE;
import static android.app.ActivityManager.INSTR_FLAG_DISABLE_TEST_API_CHECKS;
-import static android.app.ActivityManager.INSTR_FLAG_MOUNT_EXTERNAL_STORAGE_FULL;
import android.app.IActivityManager;
import android.app.IInstrumentationWatcher;
@@ -512,7 +512,7 @@ public class Instrument {
flags |= INSTR_FLAG_DISABLE_TEST_API_CHECKS;
}
if (disableIsolatedStorage) {
- flags |= INSTR_FLAG_MOUNT_EXTERNAL_STORAGE_FULL;
+ flags |= INSTR_FLAG_DISABLE_ISOLATED_STORAGE;
}
if (!mAm.startInstrumentation(cn, profileFile, flags, args, watcher, connection, userId,
abi)) {