diff options
| author | Anton Hansson <hansson@google.com> | 2020-02-19 11:35:09 +0000 |
|---|---|---|
| committer | Anton Hansson <hansson@google.com> | 2020-02-19 12:03:04 +0000 |
| commit | daa9d884442284f654be37155f6fb50689380a63 (patch) | |
| tree | 734e434d93695fc9dcaf04cd8481d001a5b768d4 | |
| parent | 5562c7e87f564661908fcb2f59591d012626ee3b (diff) | |
Enable compat checking & lint for system_services api
These were previously turned off as there were no previous
releases to compare it to. Check in empty files as comparison.
Whitelist current lint problems for now (filed bugs to follow-up).
Bug: 149818061
Bug: 149818284
Bug: 147559833
Test: m checkapi
Change-Id: Ib4cbc84ac9a826f7b947c951c94f8f5578f4554d
| -rw-r--r-- | services/Android.bp | 10 | ||||
| -rw-r--r-- | services/api/lint-baseline.txt | 35 |
2 files changed, 45 insertions, 0 deletions
diff --git a/services/Android.bp b/services/Android.bp index 416f448a965f..c77e75da66ba 100644 --- a/services/Android.bp +++ b/services/Android.bp @@ -127,6 +127,16 @@ droidstubs { api_file: "api/current.txt", removed_api_file: "api/removed.txt", }, + last_released: { + api_file: ":last-released-system-server-api", + removed_api_file: "api/removed.txt", + baseline_file: ":system-server-api-incompatibilities-with-last-released" + }, + api_lint: { + enabled: true, + new_since: ":last-released-system-server-api", + baseline_file: "api/lint-baseline.txt", + }, }, } diff --git a/services/api/lint-baseline.txt b/services/api/lint-baseline.txt new file mode 100644 index 000000000000..0b8658cf469d --- /dev/null +++ b/services/api/lint-baseline.txt @@ -0,0 +1,35 @@ +// Baseline format: 1.0 +InternalClasses: com.android.permission.persistence.RuntimePermissionsPersistence: + Internal classes must not be exposed +InternalClasses: com.android.permission.persistence.RuntimePermissionsState: + Internal classes must not be exposed +InternalClasses: com.android.permission.persistence.RuntimePermissionsState.PermissionState: + Internal classes must not be exposed +InternalClasses: com.android.role.persistence.RolesPersistence: + Internal classes must not be exposed +InternalClasses: com.android.role.persistence.RolesState: + Internal classes must not be exposed +InternalClasses: com.android.server.SystemService: + Internal classes must not be exposed +InternalClasses: com.android.server.SystemService.TargetUser: + Internal classes must not be exposed + + +ProtectedMember: com.android.server.SystemService#publishBinderService(String, android.os.IBinder): + Protected methods not allowed; must be public: method com.android.server.SystemService.publishBinderService(String,android.os.IBinder)} +ProtectedMember: com.android.server.SystemService#publishBinderService(String, android.os.IBinder, boolean): + Protected methods not allowed; must be public: method com.android.server.SystemService.publishBinderService(String,android.os.IBinder,boolean)} + + +UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#delete(android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `delete` +UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#read(android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `read` +UserHandleName: com.android.permission.persistence.RuntimePermissionsPersistence#write(com.android.permission.persistence.RuntimePermissionsState, android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `write` +UserHandleName: com.android.role.persistence.RolesPersistence#delete(android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `delete` +UserHandleName: com.android.role.persistence.RolesPersistence#read(android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `read` +UserHandleName: com.android.role.persistence.RolesPersistence#write(com.android.role.persistence.RolesState, android.os.UserHandle): + Method taking UserHandle should be named `doFooAsUser` or `queryFooForUser`, was `write` |