Age | Commit message (Collapse) | Author |
|
This CL disables SQLite's new behavior in "ALTER RENAME TABLE"
introduced in version 3.25.0 (https://www.sqlite.org/changes.html).
In this new behavior, when renaming a table, SQLite would automatically
update all the views and triggers referencing to it, which is nice if an
app is always using 3.25 or later. However, in practice, almost all
android apps have to support older android versions where this behavior
is not supported, apps just can't rely on this feature.
Other downsides of the new behavior (in the context of android ecosystem)
includes:
- Because the new behavior would crash an app when a rename would cause
a dangling view or trigger *even when the app does have a fix-up step
after ALTER RENAME TABLE* in which case it'd just work fine at the end,
it is very risky to enable the new behavior on all apps.
- This new behavior also means existing upgrade steps (which may have
been introduced years ago) could suddenly fail, if the step is executed
in R. This means, if an app used an "ALTER TABLE RENAME" in the upgrade
step from ver 1 to ver 2 five years ago and never after, and almost all
users are already running ver 2 or newer, *if* there's still a user who
are on ver 1, upgrading the app to the latest version could suddenly
fail on R.
Applications wishing to enable the new behavior can enable it at runtime
with the following call:
SQLiteDatabase db = ....; // open a DB
db.execPerConnectionSQL("PRAGMA legacy_alter_table = 0;", null);
Test: atest SQLiteSecurityTest
Bug: 147928666
Change-Id: I64546deebd3782ed685fcb46498bc487e0f8d5b6
|
|
Comment out the tokenize function. This code doesn't appear to be used.
A future change will further clean up this code and delete it properly.
Bug: 139186193
Test: compiles and boots
Change-Id: I0b2c37b6716162228205fc1ca8bea0f397f36baf
|
|
Specific min match is required for each country.
Test: Manual
Change-Id: I2f1355c4ba712170464e4c23a916024e0bf58e71
Merged-In: I2f1355c4ba712170464e4c23a916024e0bf58e71
Signed-off-by: Taesu Lee <taesu82.lee@samsung.com>
Bug:134246556
|
|
am: 6ba0946797
Change-Id: I5bddf8d087d0464f41140cabdedb58e8ff52a4cf
|
|
Maintaining external/icu for non-device usecases is
becoming an increasing burden and there are no tests
around sqlite / libsqlite on host that indicate what
support is needed.
There doesn't appear to be any ICU initialization code
in place on host suggesting ICU usage is limited to
functions that don't require data.
This change removes ICU integration with sqlite on host
entirely to try to flush out affected users. If there
are no complaints that will be one less dependency to
worry about.
Bug: 130787951
Test: build / treehugger
Test: Ran sqlite3 on host
Change-Id: Icd1eb97281d941a3f55c4289b6d65fe5921ed542
|
|
am: 08675b42a3
Change-Id: I020be050444180572c16d531b9802ba6bb5cdffb
|
|
Android build system added support for building translated binaries
used on natively bridge targets (arm on x86 for example).
However in order to avoid building unnecessary binaries and libraries
for such architectures most modules do not support native bridge by default.
All needed modules have to explicitly indicate if they may be used as part
of translated binary build.
This change enabled native bridge support for libsqlite because is a greylisted
library and needs to be available to apps targeting Andorid version < 24
Bug: http://b/77159578
Test: make
Change-Id: Idc03773014ef2ddd20e4c6b164cb5f4cd3f2d142
|
|
Bug: 129698226
Test: atest external/sqlite/android
Change-Id: Ifcea4f77f73b8f669a4f3b11a6c2e11a97580bc4
|
|
libicuuc and libicui18n are moved into APEX, but
they have no stable ABI due to the version suffix.
Use libandroidicu which provides stable symbol.
See http://go/apex-stable-icu4c-interface for the design.
Bug: 117094880
Test: m checkbuild
Merged-In: Iab88307452d9467ddebc0d4dfc5a4799ff54324f
Change-Id: Iab88307452d9467ddebc0d4dfc5a4799ff54324f
(cherry picked from commit 57caede3b8ab913890639390dbc3ee9af6c1726f)
|
|
libicuuc and libicui18n are moved into APEX, but
they have no stable ABI due to the version suffix.
Use libandroidicu which provides stable symbol.
See http://go/apex-stable-icu4c-interface for the design.
Bug: 117094880
Test: m checkbuild
Change-Id: Iab88307452d9467ddebc0d4dfc5a4799ff54324f
|
|
2384f6bc0b
am: 344ea259af
Change-Id: Ie6a11319dbbdc35637895db1e60c149e301faf9f
|
|
* Supress non-critical warnings.
Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Id116ab578184a9d43ca4a8549e78889b79ea49aa
|
|
|
|
By using vendor.cflags, SQLITE_ENABLE_ICU is on/off from Android.bp. No
need to def/undef it inside the source code.
Bug: 64514237
Test: BOARD_VNDK_VERSION=current m -j libsqlite libsqlite.vendor
Merged-In: If9771fa020e528445275281017e424a5bbc2ae99
Change-Id: If9771fa020e528445275281017e424a5bbc2ae99
(cherry picked from commit 633397eeef296584d3242d8a72790dcf11bb36fd)
|
|
There are some vendor libs that are using libsqlite. So marking it as
vendor_available.
Bug: 37560614
Test: BOARD_VNDK_VERSION=current m -j libsqlite.vendor
Change-Id: I45823c4d42071f505583a955564cdd78742e8029
Merged-In: I45823c4d42071f505583a955564cdd78742e8029
|
|
By using vendor.cflags, SQLITE_ENABLE_ICU is on/off from Android.bp. No
need to def/undef it inside the source code.
Bug: 64514237
Test: BOARD_VNDK_VERSION=current m -j libsqlite libsqlite.vendor
Change-Id: If9771fa020e528445275281017e424a5bbc2ae99
|
|
libicuuc.so isn't available for vendors, thus ICU is turned off when
libsqlite is built for vendors.
Bug: 64104535
Test: BOARD_VNDK_VERSION=current m -j libsqlite.vendor
Merged-In: I682502ba5bdc5f76a0363a95d01b1081c1bc01a4
Change-Id: I682502ba5bdc5f76a0363a95d01b1081c1bc01a4
(cherry picked from commit b4076dfd66f114263a1f70cf3ba73c2d55ccb3b0)
|
|
libicuuc.so isn't available for vendors, thus ICU is turned off when
libsqlite is built for vendors.
Bug: 64104535
Test: BOARD_VNDK_VERSION=current m -j libsqlite.vendor
Change-Id: I682502ba5bdc5f76a0363a95d01b1081c1bc01a4
|
|
Previously when comparing local phone numbers with
international it was possible to match the wrong number
because the first digit of the area code was being treated
as a skippable trunk digit, e.g:
"550-123-4567" would be considered equal to "+14501234567".
Since there are two different algorithms (loose/old and strict)
there are two solutions with the same basic goal:
Only ignore mismatches if there's an actual extra digit which
could possibly be the trunk digit, i.e: "0550-123-4567" is acceptable
as equal to "+15501234567". NB: The US not having a trunk digit
to begin with is a different issue entirely - the code is agnostic on
which country has which trunk digits!
For "loose" matching we achieve this by checking the length of the
mismatch.
For "strict" matching we keep track of the supposed trunk digit
and compare it against the current position in match. So for the above
example 5 != 4.
Several new unit tests were added (including replicating tests for
OldPhoneNumberUtils). I broke down the c++ tests into smaller methods
for additional readability.
NB: By adding more tests I uncovered that two digit trunk prefixes
were never handled correctly for the "strict" matching case. "Loose"
matching is much more robust. I commented out the "strict" test cases.
Test: All unit tests pass for PhoneNumberUtilsTest,
OldPhoneNumberUtilsTest and DatabaseGeneralTest.
Bug: 63179537
Bug: 63178542
Bug: 62916088
Change-Id: Idc2a1c2c2f64ed29995208503de4755c521e1c82
|
|
There are some vendor libs that are using libsqlite. So marking it as
vendor_available.
Bug: 37560614
Test: BOARD_VNDK_VERSION=current m -j libsqlite.vendor
Change-Id: I45823c4d42071f505583a955564cdd78742e8029
|
|
See build/soong/README.md for more information.
Test: m -j checkbuild
Change-Id: I649eecd3948fbe49bb153b14a8eae9b110a79734
|
|
Removes dead use of deprecated ucol_getShortDefinitionString.
Converts PhoneNumberUtils tests to gtest.
Bug: http://b/31459453
Change-Id: I4662e25d711868e21afb0661602c64852f0cef65
|
|
These modules can be named the same between the target and host
libraries, which simplifies references to them, particularly in
Soong.
To prevent accidentally loading the system copy of the library,
we still rename the installed name to be libicu*-host.so. But
modules do not need to know that in order to build against them.
Change-Id: I4735599feb73225b2bea6dee42bbc23118693765
|
|
ICU exports them using LOCAL_EXPORT_C_INCLUDE_DIRS.
bug: 18581021
Change-Id: I98048a4f6a9163fff6d3a71712d8249b2b00d04b
|
|
Change-Id: I16a4b5c0d7b46a4edd61d75ba017669b0daafc90
|
|
Bug: 13751317
Change-Id: I64e66eb34dbe10b39ec2e8c37da0038705b4931f
|
|
Change-Id: I21a4e18f0d2aacaf76421b62d693c2ae7eb08f30
|
|
* commit 'b4e9e379e360464d3d6bde3084e5b286238a9329':
fix build problem, when #define ENABLE_ANDROID_LOG 1
|
|
Change-Id: I514750dd33ff5bd433d4ee167a2401d829d2fbe9
|
|
Remove sqlite GET_PHONEBOOK_INDEX callback.
Bug:
Change-Id: I751bb4fdff89af1eccc4b21b67fddd0b802eeb61
|
|
Switch ContactsProvider to using ICU for generation of index labels,
and remove custom KO and JA code. Add i18n test cases.
Bug:7351596
Change-Id: I7ac25add8b29ff2c6c395f04a83b279b541e4125
|
|
Japanese kana characters"
* commit '38d33f70401037d36fcad72c4b4199890755a66b':
GetPhonebookIndex: Fix handling for minor Japanese kana characters
|
|
See https://android-git.corp.google.com/g/#/c/157220
Bug: 5449033
Change-Id: I5ffb58901712f4db93de474c30833a46ebb4bc7c
|
|
See https://android-git.corp.google.com/g/156016
Bug: 5449033
Change-Id: Iad9bddb01ef0d9b28e3969b9f8dfbb2cc2830b30
|
|
This adds minor Japanese kana character handling to meet the
unicode collation algorithm.
-Normalize digraphs (yori, koto) into first reading letter.
-Treat dakuten, dot, onbiki, iteration marks as a symbol.
-Add handling for minor small katakana letter.
Signed-off-by: Yutaro Ogasawara <yutaro.ogasawara@gmail.com>
|
|
Change-Id: I5281dda013f909c050fda712d3a0816173df277d
Signed-off-by: Mike Lockwood <lockwood@android.com>
|
|
The media provider is now using the emulated /mnt/sdcard file system,
so this change is no longer necessary.
This reverts commit 439e88e7d09bfeac4690f2d9df6533955aa4fa88.
Change-Id: Ied12275767e3a399d7e455ac2102527ccd8b888d
|
|
Bug: 3210604
Change-Id: Ie65c053ec5178d6cd991f69a5a2b6d5d51938ade
|
|
Change-Id: Ibb9ca5833f9c0b3313ff0e9bc70348d268aaf4e2
|
|
Change-Id: I8a3f620cd6633f2be47ac05e17ea642f00b71e91
Signed-off-by: Mike Lockwood <lockwood@android.com>
|
|
Change-Id: Ifa97db751da1aeeeb9d7450b04c909f0800ce140
|
|
Change-Id: I900daf7f205f8f666eac9c4070d2e5c99d85b3b3
|
|
Needed for simulator build on newer Ubuntu distributions.
Based on Ibb8cd3cdb4feae89a20eec56131e322f39721b1a
Change-Id: Ie574888128265e026973a5ac88ede87730eda7d4
|
|
Change-Id: I5f3ae179d388c417abd512974df22fd78a699354
|
|
Needed for simulator build on newer Ubuntu distributions.
Change-Id: Ibb8cd3cdb4feae89a20eec56131e322f39721b1a
Signed-off-by: Mike Lockwood <lockwood@android.com>
|
|
based on phonebook
in ja_JP locale.
In the future, we may able to use PHONEBOOK_COLLATOR in the other locales, but we don't use
the other phonebook collator now since we cannot estimate how impactful the change is.
Now we have a customized phonebook collator in Japanese and we need it in ContactsProvider,
we'll use only the collator.
Do not use this collator in the other packages and locales now. We may decide revert it in the
near future after furter investigatons.
Need to submit I4dd1b047 to make this change actually effective. Without the change,
we will have a phonebook collator for "previous" locale, not the current one.
Bug: 2514026
Bug: 2373557
Bug: 2373553
Change-Id: If6f548c0a80fe01e779b4dfc46f74224003f1798
|
|
are now obsolete because we already have icu's collator.
Remain getNormalizedString() but remove SQLite variant since the C function is used internally.
Change-Id: If1e4b8388087b78e0f6418ac3c7be4c23f67ee0e
|
|
Change-Id: I9d5bd02f23882dd85e91075e897150cafa33ffe5
|
|
Bug: 2487471
Change-Id: I90cef4eb2468c0a58067df984ee98da438aa0e5a
|
|
Bug: 2407129
Change-Id: I8d83f9012846f61484b76f718e8127090eba39ec
|