summaryrefslogtreecommitdiff
path: root/pngpread.c
diff options
context:
space:
mode:
authorGlenn Randers-Pehrson <glennrp at users.sourceforge.net>2017-08-03 12:43:56 -0500
committerGlenn Randers-Pehrson <glennrp at users.sourceforge.net>2017-08-03 12:43:56 -0500
commit095b4ce16bb46acb259ea1a4ca6562a623e58d93 (patch)
treef818bd9b63e5df4d061cafa1feff2b73b1b56d25 /pngpread.c
parentbfdabdacff713fe4dec914c048d6a88441f834cb (diff)
[libpng16] Disabled new limit test on IDAT chunks. It was producing too small
a limit for some files.
Diffstat (limited to 'pngpread.c')
-rw-r--r--pngpread.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/pngpread.c b/pngpread.c
index fcee949ee..6445623d5 100644
--- a/pngpread.c
+++ b/pngpread.c
@@ -226,14 +226,19 @@ png_push_read_chunk(png_structrp png_ptr, png_inforp info_ptr)
if (chunk_name == png_IDAT)
{
+#if 0 /* some pngtests are failing */
size_t row_factor =
- (png_ptr->rowbytes + 1 + (png_ptr->interlaced? 6: 0));
+ (png_ptr->width * png_ptr->channels * (png_ptr->bit_depth > 8? 2: 1)
+ + 1 + (png_ptr->interlaced? 6: 0));
if (png_ptr->height > PNG_UINT_32_MAX/row_factor)
limit=PNG_UINT_31_MAX;
else
limit = png_ptr->height * row_factor;
limit += 6 + 5*limit/32566; /* zlib+deflate overhead */
limit=limit < PNG_UINT_31_MAX? limit : PNG_UINT_31_MAX;
+#else
+ limit=PNG_UINT_31_MAX;
+#endif
}
else
{
@@ -247,7 +252,11 @@ png_push_read_chunk(png_structrp png_ptr, png_inforp info_ptr)
# endif
}
if (png_ptr->push_length > limit)
+ {
+ printf(" png_ptr->push_length = %lu, limit = %lu\n",
+ (unsigned long)png_ptr->push_length,(unsigned long)limit);
png_chunk_error(png_ptr, "chunk data is too large");
+ }
if (chunk_name == png_IHDR)
{