| Age | Commit message (Collapse) | Author |
|---|
|
Update Chromium's copy of libjpeg-turbo to the latest upstream
release (v2.0.90) and re-apply our local changes documented in
README.chromium.
Cherry-pick two additional changes from upstream to fix bugs found
by fuzzers:
1) https://github.com/libjpeg-turbo/libjpeg-turbo/commit/ccaba5d7894ecfb5a8f11e48d3f86e1f14d5a469
2) https://github.com/libjpeg-turbo/libjpeg-turbo/commit/c7ca521bc85b57d41d3ad4963c13fc0100481084
Significant changes provided by this update:
1) A large performance boost to JPEG encoding due to an improved
Huffman encoding implementation.
2) The complete removal of Arm Neon assembly code. This allows Arm's
control-flow integrity security features (Armv8.3-A Pointer
Authentication and Armv8.5-A Branch Target Identification) to be
switched on with the appropriate compiler flags.
Bug: 922430
Bug: b/135180511
Bug: 919548, 1145581
Change-Id: I319fcdc55b3fd5b219425c07a4e4a03587f4e06d
|
|
ALIGN_SIZE is defined to be 32 bytes in order to accommodate AVX2's
alignment requirements. Arm NEON only requires 16-byte alignment but
software optimizations are possible if 32-byte alignment is assumed
for memory allocated by jmemmgr.c.
This patch introduces a compile-time check to make sure that
ALIGN_SIZE is a multiple of 32 bytes for Arm NEON systems.
Optimizations relying on this assumption for Arm NEON will follow
this CL.
Bug: 922430
Change-Id: I57f349eeffa704ec6c440f356a607964fc4fc8cc
|
|
SIMD architectures have different memory alignment requirements which
must be complied with to prevent performance - and more importantly -
security issues.
This patch introduces an explicit compile-time check to make sure
that ALIGN_SIZE is a multiple of 32 bytes for AVX2 and a multiple of
16 bytes for all other architectures.
Future Arm NEON performance patches will rely on this behaviour in
the memory manager for correctness.
Bug: 922430
Change-Id: I8cf0503fba301baa6505459e3308ba89e670cc26
|
|
In order to apply some performance updates from ARM, we need to update
libjpeg-turbo. These performance updates have yielded a 50% speedup on
some devices.
This CL updates our copy of libjpeg-turbo to v2.0.1 and re-applies our
local patches. This patch also deletes some extra files which were not
being used locally.
Update our local patch that was applied to fix http://crbug.com/398235
(https://codereview.appspot.com/229430043/). The original patch
incorrectly removed "& 0xFF" which limited an array index to within
that array's bounds (effectively reverting
https://github.com/libjpeg-turbo/libjpeg-turbo/commit/fa1d18385d904d530b4aec83ab7757a33397de6e).
Restore the mask, making the array access safe and fixing a graphical
glitch which would otherwise be introduced by this change.
Bug:922430
Change-Id: I3860fdb424deecf7a17818ed09a640e632e71f8d
|
|
(Duplicate of https://codereview.chromium.org/1939823002/ for landing.)
TBR=noel@chromium.org,thakis@chromium.org
BUG=608347, 398235, 591927
Review URL: https://codereview.chromium.org/1953443002 .
|
|
This change updates our copy of libjpeg-turbo to 1.1.90 (r677), which supports ARM NEON.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7554002
git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/libjpeg_turbo@95196 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
|
|
This change lands the original libjpeg-turbo 1.0.1 (source files only) and NASM 2.09.2 (required for assembling .asm files on Windows) to "deps/third_party". I will send more changes to land its build files and patches to integrate it into Chrome.
BUG=48789
TEST=none
Review URL: http://codereview.chromium.org/4134011
git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/libjpeg_turbo@64575 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
|
