diff options
| author | Gao Xiang <hsiangkao@aol.com> | 2020-11-21 10:26:22 +0800 |
|---|---|---|
| committer | Gao Xiang <hsiangkao@aol.com> | 2020-11-21 15:38:36 +0800 |
| commit | 8d6777c98e7fe6c055cc33954c0d69be31340a29 (patch) | |
| tree | e7d0e235f2960cddb8ceb8a661ea4ea3a74b08a1 | |
| parent | 1fbd7c8bc4bd02091d8d5785128604f7c9627dbf (diff) | |
erofs-utils: drop known issue in README
Since lz4-1.9.3 has been released,
https://github.com/lz4/lz4/releases/tag/v1.9.3
Move this lz4hc issue (lz4 <= 1.9.2) to "Comments" instead.
Link: https://lore.kernel.org/r/20201121022623.3882-1-hsiangkao@aol.com
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
Signed-off-by: Gao Xiang <hsiangkao@aol.com>
| -rw-r--r-- | README | 27 |
1 files changed, 12 insertions, 15 deletions
@@ -19,7 +19,7 @@ It can create 2 primary kinds of erofs images: (un)compressed. Dependencies ~~~~~~~~~~~~ - lz4-1.8.0+ for lz4 enabled [2], lz4-1.9.0+ recommended + lz4-1.8.0+ for lz4 enabled [2], lz4-1.9.3+ recommended [4]. How to build for lz4-1.9.0 or above ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -48,7 +48,7 @@ On Fedora, static lz4 can be installed using: yum install lz4-static.x86_64 However, it's not recommended to use those versions since there were bugs -in these compressors, see [2] [3] as well. +in these compressors, see [2] [3] [4] as well. How to generate erofs images ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ @@ -70,19 +70,6 @@ add "-E legacy-compress" to the command line, e.g. $ mkfs.erofs -E legacy-compress -zlz4hc foo.erofs.img foo/ - -Known issues -~~~~~~~~~~~~ - -1. LZ4HC cannot compress long zeroed buffer properly with - LZ4_compress_HC_destSize() - https://github.com/lz4/lz4/issues/784 - - which has been resolved in - https://github.com/lz4/lz4/commit/e7fe105ac6ed02019d34731d2ba3aceb11b51bb1 - - and will be included in lz4-1.9.3 if all goes well. - Obsoleted erofs.mkfs ~~~~~~~~~~~~~~~~~~~~ @@ -149,3 +136,13 @@ Comments version as well) or backport all stable bugfixes to old stable versions, e.g. our unoffical lz4 fork: https://github.com/erofs/lz4 +[4] LZ4HC didn't compress long zeroed buffer properly with + LZ4_compress_HC_destSize() + https://github.com/lz4/lz4/issues/784 + + which has been resolved in + https://github.com/lz4/lz4/commit/e7fe105ac6ed02019d34731d2ba3aceb11b51bb1 + + and already included in lz4-1.9.3, see: + https://github.com/lz4/lz4/releases/tag/v1.9.3 + |