summaryrefslogtreecommitdiff
path: root/java/java.go
diff options
context:
space:
mode:
authorPeter Collingbourne <pcc@google.com>2019-12-17 16:46:18 -0800
committerPeter Collingbourne <pcc@google.com>2019-12-17 16:55:20 -0800
commitad84f975d2cf6eedb2bc3aa4f027b9c0a3664d83 (patch)
tree45d935e1772b5a6a6102a4e33b592a15e9308719 /java/java.go
parent9fd9b92d518cd354c54aaf87b160aaaefa48ea35 (diff)
Reland "Also package recursive jni_libs deps of android_apps as well as direct deps." with bug fix.
This time, exclude NDK libraries instead of LLNDK libraries from the package. This is necessary because there are libraries such as libvndksupport which are LLNDK but are not accessible to apps. Original commit message: > Previously, android_app targets for which a.shouldEmbedJnis(ctx) = true > (e.g. CtsSelinuxTargetSdk25TestCases) would need to specify all of their > recursive library dependencies, including for example libc++ when depending > on the platform libc++. This means unnecessary churn when we add a new > dependency to libc++ (e.g. libunwind [1]). To avoid the churn and allow > jni_libs clauses to be simplified, make the build system search for the > recursive dependencies and automatically include them. > > This change allows us to remove code that was previously adding NDK libc++ > as a special case, as it is now covered by the generic code. > > Also fix some improper quoting that was exposed as a result of this change > causing more files to be packaged than before. > > [1] https://android-review.googlesource.com/q/topic:%22libunwind-so%22 Bug: 144430859 Test: atest CtsAppOpsTestCases Test: atest FrameworksNetSmokeTests Change-Id: I8311ede0b44d7e50b9f272912ead8ef07e82b074
Diffstat (limited to 'java/java.go')
-rw-r--r--java/java.go1
1 files changed, 0 insertions, 1 deletions
diff --git a/java/java.go b/java/java.go
index 59bfaf758..9745da45e 100644
--- a/java/java.go
+++ b/java/java.go
@@ -466,7 +466,6 @@ type dependencyTag struct {
type jniDependencyTag struct {
blueprint.BaseDependencyTag
- target android.Target
}
func IsJniDepTag(depTag blueprint.DependencyTag) bool {