summaryrefslogtreecommitdiff
path: root/tools/warn/java_warn_patterns.py
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2020-01-29 11:01:36 -0800
committerChih-Hung Hsieh <chh@google.com>2020-01-29 11:01:36 -0800
commitb09530bd6585c2ee772b828bbb97934c747734bb (patch)
treeec0c226461a250784888f1cecee57a2d7fcc1d15 /tools/warn/java_warn_patterns.py
parent5c3725510a349d0492b341bd2b4efe8a06bc43a7 (diff)
Add new C++ and Java warning patterns
Test: warn.py --url=http://cs/android --separator='?l=' build.log > warnings.html Test: warn.py --gencsv build.log > warnings.csv Change-Id: I11457fdab7abd475e835367582c0b9aab11cfe6f
Diffstat (limited to 'tools/warn/java_warn_patterns.py')
-rw-r--r--tools/warn/java_warn_patterns.py11
1 files changed, 11 insertions, 0 deletions
diff --git a/tools/warn/java_warn_patterns.py b/tools/warn/java_warn_patterns.py
index 0a443d4835..96510b4e56 100644
--- a/tools/warn/java_warn_patterns.py
+++ b/tools/warn/java_warn_patterns.py
@@ -38,6 +38,10 @@ def java_medium(description, pattern_list):
return java_warn(Severity.MEDIUM, description, pattern_list)
+def java_medium_type(name):
+ return java_medium(name, [r'.*\.java:.*: warning: .+ \[' + name + r'\]$'])
+
+
def java_low(description, pattern_list):
return java_warn(Severity.LOW, description, pattern_list)
@@ -457,6 +461,13 @@ warn_patterns = [
[r".*: warning: \[WaitNotInLoop\] .+"]),
java_medium('A wakelock acquired with a timeout may be released by the system before calling `release`, even after checking `isHeld()`. If so, it will throw a RuntimeException. Please wrap in a try/catch block.',
[r".*: warning: \[WakelockReleasedDangerously\] .+"]),
+ java_medium_type('CallbackName'),
+ java_medium_type('ExecutorRegistration'),
+ java_medium_type('ListenerLast'),
+ java_medium_type('MissingBuildMethod'),
+ java_medium_type('NoByteOrShort'),
+ java_medium_type('SetterReturnsThis'),
+ java_medium_type('UseIcu'),
java_high('AndroidInjection.inject() should always be invoked before calling super.lifecycleMethod()',
[r".*: warning: \[AndroidInjectionBeforeSuper\] .+"]),
java_high('Use of class, field, or method that is not compatible with legacy Android devices',