diff options
author | Bernie Innocenti <codewiz@google.com> | 2019-03-28 15:48:08 +0900 |
---|---|---|
committer | Bernie Innocenti <codewiz@google.com> | 2019-03-28 17:28:13 +0900 |
commit | 8bd6f455d261fa62a20321a426723c491903a82e (patch) | |
tree | 0864259080dd9934b15435fe4b3500b45485f895 /fuse_sideload/fuse_sideload.cpp | |
parent | 3168ddf79dee2b7256eb43b404dad5c3a0d71af2 (diff) |
Fix bogus error checking on unique_fd
The expression "!fd" calls the implicit conversion to int, but comparing
the raw fd against 0 does not work, since open() and other POSIX calls
returning a file descriptor use -1 to signal an error.
Test: m recovery
Change-Id: I0847c276f39cb9dd09c7ffb96951276113418fc8
Diffstat (limited to 'fuse_sideload/fuse_sideload.cpp')
-rw-r--r-- | fuse_sideload/fuse_sideload.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fuse_sideload/fuse_sideload.cpp b/fuse_sideload/fuse_sideload.cpp index b5b6ac15..3d948030 100644 --- a/fuse_sideload/fuse_sideload.cpp +++ b/fuse_sideload/fuse_sideload.cpp @@ -392,7 +392,7 @@ int run_fuse_sideload(std::unique_ptr<FuseDataProvider>&& provider, const char* } fd.ffd.reset(open("/dev/fuse", O_RDWR)); - if (!fd.ffd) { + if (fd.ffd == -1) { perror("open /dev/fuse"); result = -1; goto done; |