diff options
Diffstat (limited to 'libc/include/bits/fortify/stdio.h')
-rw-r--r-- | libc/include/bits/fortify/stdio.h | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/libc/include/bits/fortify/stdio.h b/libc/include/bits/fortify/stdio.h index 0b5700a0a..6e47dafee 100644 --- a/libc/include/bits/fortify/stdio.h +++ b/libc/include/bits/fortify/stdio.h @@ -57,8 +57,7 @@ int vsprintf(char* const __pass_object_size dest, const char* format, va_list ap __BIONIC_ERROR_FUNCTION_VISIBILITY int snprintf(char* dest, size_t size, const char* format) __overloadable - __enable_if(__bos(dest) != __BIONIC_FORTIFY_UNKNOWN_SIZE && - __bos(dest) < __builtin_strlen(format), + __enable_if(__bos_unevaluated_lt(__bos(dest), __builtin_strlen(format)), "format string will always overflow destination buffer") __errorattr("format string will always overflow destination buffer"); @@ -75,8 +74,7 @@ int snprintf(char* const __pass_object_size dest, size_t size, const char* forma __BIONIC_ERROR_FUNCTION_VISIBILITY int sprintf(char* dest, const char* format) __overloadable - __enable_if(__bos(dest) != __BIONIC_FORTIFY_UNKNOWN_SIZE && - __bos(dest) < __builtin_strlen(format), + __enable_if(__bos_unevaluated_lt(__bos(dest), __builtin_strlen(format)), "format string will always overflow destination buffer") __errorattr("format string will always overflow destination buffer"); @@ -91,16 +89,20 @@ int sprintf(char* const __pass_object_size dest, const char* format, ...) __over #endif /* __ANDROID_API__ >= __ANDROID_API_J_MR1__ */ #if __ANDROID_API__ >= __ANDROID_API_N__ +#define __bos_trivially_not_lt_mul(bos_val, size, count) \ + __bos_dynamic_check_impl_and(bos_val, >=, (size) * (count), \ + !__unsafe_check_mul_overflow(size, count)) + __BIONIC_FORTIFY_INLINE size_t fread(void* const __pass_object_size0 buf, size_t size, size_t count, FILE* stream) __overloadable __clang_error_if(__unsafe_check_mul_overflow(size, count), "in call to 'fread', size * count overflows") - __clang_error_if(__bos(buf) != __BIONIC_FORTIFY_UNKNOWN_SIZE && size * count > __bos(buf), + __clang_error_if(__bos_unevaluated_lt(__bos0(buf), size * count), "in call to 'fread', size * count is too large for the given buffer") { size_t bos = __bos0(buf); - if (bos == __BIONIC_FORTIFY_UNKNOWN_SIZE) { + if (__bos_trivially_not_lt_mul(bos, size, count)) { return __call_bypassing_fortify(fread)(buf, size, count, stream); } return __fread_chk(buf, size, count, stream, bos); @@ -111,16 +113,17 @@ size_t fwrite(const void* const __pass_object_size0 buf, size_t size, size_t cou __overloadable __clang_error_if(__unsafe_check_mul_overflow(size, count), "in call to 'fwrite', size * count overflows") - __clang_error_if(__bos(buf) != __BIONIC_FORTIFY_UNKNOWN_SIZE && size * count > __bos(buf), + __clang_error_if(__bos_unevaluated_lt(__bos0(buf), size * count), "in call to 'fwrite', size * count is too large for the given buffer") { size_t bos = __bos0(buf); - if (bos == __BIONIC_FORTIFY_UNKNOWN_SIZE) { + if (__bos_trivially_not_lt_mul(bos, size, count)) { return __call_bypassing_fortify(fwrite)(buf, size, count, stream); } return __fwrite_chk(buf, size, count, stream, bos); } +#undef __bos_trivially_not_lt_mul #endif /* __ANDROID_API__ >= __ANDROID_API_N__ */ #if __ANDROID_API__ >= __ANDROID_API_J_MR1__ @@ -128,11 +131,11 @@ __BIONIC_FORTIFY_INLINE char* fgets(char* const __pass_object_size dest, int size, FILE* stream) __overloadable __clang_error_if(size < 0, "in call to 'fgets', size should not be negative") - __clang_error_if(size > __bos(dest), + __clang_error_if(__bos_unevaluated_lt(__bos(dest), size), "in call to 'fgets', size is larger than the destination buffer") { size_t bos = __bos(dest); - if (bos == __BIONIC_FORTIFY_UNKNOWN_SIZE) { + if (__bos_dynamic_check_impl_and(bos, >=, (size_t)size, size >= 0)) { return __call_bypassing_fortify(fgets)(dest, size, stream); } |