summaryrefslogtreecommitdiff
path: root/tools/generate-version-script.py
diff options
context:
space:
mode:
authorJeremy Compostella <jeremy.compostella@intel.com>2018-04-10 16:16:14 -0700
committerElliott Hughes <enh@google.com>2018-04-20 17:33:12 -0700
commit592bf711fdf273ff8a61b32e12cd886897922335 (patch)
treec410a83ac06ca6270cde2611fbad9d408fae6629 /tools/generate-version-script.py
parent4c9504aa6cb4dad5142056d5e46bcb8409fd476d (diff)
Revert "Add 64-bit slm optimized strlcpy and srlcat."
This reverts commit 2e7145c048e15bf6646befd70aa08d1bfe7b6c26. When src is at the end page, the sse2 strlcpy SSE2 optimized version can issue a movdqu instruction that can cross the page boundary. If the next page is not allocated to that process, it leads to segmentation fault. This is a rare but has be caught multiple times during robustness testing. We isolated a way to reproduce that issue outside of an Android device and we have been able to resolve this particular case. However, we ran some additional compliance and robustness tests and found several other similar page crossing issues with this implementation. In conclusion, this optimization needs to be re-written from scratch because its design is at cause. In the meantime, it is better to remove it. Bug: http://b/78355649 Change-Id: If90450de430ba9b7cd9282a422783beabd701f3d Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com> (cherry picked from commit 611ad621c670a94dadf51562b6256b24f1247981)
Diffstat (limited to 'tools/generate-version-script.py')
0 files changed, 0 insertions, 0 deletions