diff options
author | Elliott Hughes <enh@google.com> | 2019-03-08 15:20:23 -0800 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2019-03-12 10:26:39 -0700 |
commit | bcaa454d32e1b4ccf92467bb263d627695ac9a5b (patch) | |
tree | 65d7d4c493242ecb51bfe1796f133b32538de514 /tests/stdio_test.cpp | |
parent | ff16c0b89b7297bc70353f60afac9bb93d6b0087 (diff) |
bionic tests: use GTEST_SKIP.
Also be a bit more to the point in our messages, focusing on "why" not
"what".
Test: ran tests
Change-Id: I297806c7a102bd52602dcd2fcf7a2cd34aba3a11
Diffstat (limited to 'tests/stdio_test.cpp')
-rw-r--r-- | tests/stdio_test.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tests/stdio_test.cpp b/tests/stdio_test.cpp index ad6ed45a9..65a942c37 100644 --- a/tests/stdio_test.cpp +++ b/tests/stdio_test.cpp @@ -330,7 +330,7 @@ TEST(STDIO_TEST, snprintf_n) { int i = 1234; EXPECT_DEATH(snprintf(buf, sizeof(buf), "a %n b", &i), "%n not allowed on Android"); #else - GTEST_LOG_(INFO) << "This test does nothing on glibc.\n"; + GTEST_SKIP() << "glibc does allow %n"; #endif } @@ -1897,7 +1897,7 @@ TEST(STDIO_TEST, open_memstream_EINVAL) { ASSERT_EQ(nullptr, open_memstream(&p, nullptr)); ASSERT_EQ(EINVAL, errno); #else - GTEST_LOG_(INFO) << "This test does nothing on glibc.\n"; + GTEST_SKIP() << "glibc is broken"; #endif } @@ -2157,7 +2157,7 @@ TEST(STDIO_TEST, fseek_ftell_unseekable) { fclose(fp); #else - GTEST_LOG_(INFO) << "glibc uses fopencookie instead.\n"; + GTEST_SKIP() << "glibc uses fopencookie instead"; #endif } @@ -2167,7 +2167,7 @@ TEST(STDIO_TEST, funopen_EINVAL) { ASSERT_EQ(nullptr, funopen(nullptr, nullptr, nullptr, nullptr, nullptr)); ASSERT_EQ(EINVAL, errno); #else - GTEST_LOG_(INFO) << "glibc uses fopencookie instead.\n"; + GTEST_SKIP() << "glibc uses fopencookie instead"; #endif } @@ -2195,7 +2195,7 @@ TEST(STDIO_TEST, funopen_seek) { EXPECT_EQ(0, fgetpos64(fp64, &pos64)) << strerror(errno); EXPECT_EQ(0xfedcba12345678, pos64); #else - GTEST_LOG_(INFO) << "glibc uses fopencookie instead.\n"; + GTEST_SKIP() << "glibc uses fopencookie instead"; #endif } @@ -2234,7 +2234,7 @@ static void AssertFileOffsetAt(FILE* fp, off64_t offset) { EXPECT_EQ(offset, static_cast<off64_t>(pos)); EXPECT_EQ(offset, static_cast<off64_t>(pos64)); #else - GTEST_LOG_(INFO) << "glibc's fpos_t is opaque.\n"; + GTEST_SKIP() << "glibc's fpos_t is opaque"; #endif } |