summaryrefslogtreecommitdiff
path: root/linker/linker.cpp
diff options
context:
space:
mode:
authorKiyoung Kim <kiyoungkim@google.com>2019-12-13 12:19:56 +0900
committerKiyoung Kim <kiyoungkim@google.com>2019-12-13 13:59:00 +0900
commitef04c80bf6416e2169a9d5d501f13c340b5949e9 (patch)
treefdcb65c635aa193631a6a7c0d88c266100ca7d5b /linker/linker.cpp
parent024f067061c3c8000acf8b3a07fe421cb9e02b51 (diff)
Enable linker configuration from generator by default
Current linker configuration is only enabled from fully treblelized devices. This change will allow linker to first check generated linker configuration even for non-treblelized devices and recovery. Bug: 139638519 Test: Tested from cuttlefish Change-Id: I655b1ab807cd8db5696d07fd2bdd00ce0558901d
Diffstat (limited to 'linker/linker.cpp')
-rw-r--r--linker/linker.cpp25
1 files changed, 12 insertions, 13 deletions
diff --git a/linker/linker.cpp b/linker/linker.cpp
index 2f5232769..4bcb89695 100644
--- a/linker/linker.cpp
+++ b/linker/linker.cpp
@@ -4054,19 +4054,6 @@ static std::string get_ld_config_file_vndk_path() {
return kLdConfigVndkLiteFilePath;
}
- // Use generated linker config if flag is set
- // TODO(b/138920271) Do not check property once it is confirmed as stable
- // TODO(b/139638519) This file should also cover legacy or vndk-lite config
- if (android::base::GetProperty("ro.vndk.version", "") != "" &&
- android::base::GetBoolProperty("sys.linker.use_generated_config", true)) {
- if (file_exists(kLdGeneratedConfigFilePath)) {
- return kLdGeneratedConfigFilePath;
- } else {
- DL_WARN("Warning: failed to find generated linker configuration from \"%s\"",
- kLdGeneratedConfigFilePath);
- }
- }
-
std::string ld_config_file_vndk = kLdConfigFilePath;
size_t insert_pos = ld_config_file_vndk.find_last_of('.');
if (insert_pos == std::string::npos) {
@@ -4095,6 +4082,18 @@ static std::string get_ld_config_file_path(const char* executable_path) {
path.c_str(), executable_path);
}
+ // Use generated linker config if flag is set
+ // TODO(b/138920271) Do not check property once it is confirmed as stable
+ if (android::base::GetBoolProperty("sys.linker.use_generated_config", true)) {
+ if (file_exists(kLdGeneratedConfigFilePath)) {
+ return kLdGeneratedConfigFilePath;
+ } else {
+ DL_WARN("Warning: failed to find generated linker configuration from \"%s\"",
+ kLdGeneratedConfigFilePath);
+ }
+ }
+
+
path = kLdConfigArchFilePath;
if (file_exists(path.c_str())) {
return path;