summaryrefslogtreecommitdiff
path: root/libc
diff options
context:
space:
mode:
authorChih-Hung Hsieh <chh@google.com>2019-01-02 10:59:48 -0800
committerChih-Hung Hsieh <chh@google.com>2019-01-02 11:04:05 -0800
commit770032ddfa31f6ed18e6ec85013b7939cd291eb0 (patch)
tree28dc26ae8a6b3623e79d1bb2b19fd5362477843c /libc
parent7bd54ade8d12762ef6bdb0096f3838261f14eee5 (diff)
Fix/suppress bionic google-explicit-constructor warnings
* Add explicit to conversion constructors/operators Bug: 28341362 Test: make with WITH_TIDY=1 DEFAULT_GLOBAL_TIDY_CHECKS=-*,google-explicit-constructor Change-Id: Id1ad0327c1b8c6f094bcbb3ae599bc1f716b3f2f
Diffstat (limited to 'libc')
-rw-r--r--libc/bionic/pthread_internal.cpp2
-rw-r--r--libc/malloc_debug/PointerData.h2
-rw-r--r--libc/private/ScopedReaddir.h4
-rw-r--r--libc/private/ScopedSignalHandler.h2
-rw-r--r--libc/private/bionic_lock.h2
5 files changed, 6 insertions, 6 deletions
diff --git a/libc/bionic/pthread_internal.cpp b/libc/bionic/pthread_internal.cpp
index 2b7a99a2d..c058384a2 100644
--- a/libc/bionic/pthread_internal.cpp
+++ b/libc/bionic/pthread_internal.cpp
@@ -43,7 +43,7 @@ static pthread_rwlock_t g_thread_list_lock = PTHREAD_RWLOCK_INITIALIZER;
template <bool write> class ScopedRWLock {
public:
- ScopedRWLock(pthread_rwlock_t* rwlock) : rwlock_(rwlock) {
+ explicit ScopedRWLock(pthread_rwlock_t* rwlock) : rwlock_(rwlock) {
(write ? pthread_rwlock_wrlock : pthread_rwlock_rdlock)(rwlock_);
}
diff --git a/libc/malloc_debug/PointerData.h b/libc/malloc_debug/PointerData.h
index b05a76383..6955c9a03 100644
--- a/libc/malloc_debug/PointerData.h
+++ b/libc/malloc_debug/PointerData.h
@@ -112,7 +112,7 @@ struct ListInfoType {
class PointerData : public OptionData {
public:
- PointerData(DebugData* debug_data);
+ explicit PointerData(DebugData* debug_data);
virtual ~PointerData() = default;
bool Initialize(const Config& config);
diff --git a/libc/private/ScopedReaddir.h b/libc/private/ScopedReaddir.h
index dc22309ce..9a20c0916 100644
--- a/libc/private/ScopedReaddir.h
+++ b/libc/private/ScopedReaddir.h
@@ -22,10 +22,10 @@
class ScopedReaddir {
public:
- ScopedReaddir(const char* path) : ScopedReaddir(opendir(path)) {
+ explicit ScopedReaddir(const char* path) : ScopedReaddir(opendir(path)) {
}
- ScopedReaddir(DIR* dir) {
+ explicit ScopedReaddir(DIR* dir) {
dir_ = dir;
}
diff --git a/libc/private/ScopedSignalHandler.h b/libc/private/ScopedSignalHandler.h
index dd5823f03..703175223 100644
--- a/libc/private/ScopedSignalHandler.h
+++ b/libc/private/ScopedSignalHandler.h
@@ -33,7 +33,7 @@ class ScopedSignalHandler {
sigaction64(signal_number_, &action_, &old_action_);
}
- ScopedSignalHandler(int signal_number) : signal_number_(signal_number) {
+ explicit ScopedSignalHandler(int signal_number) : signal_number_(signal_number) {
sigaction64(signal_number, nullptr, &old_action_);
}
diff --git a/libc/private/bionic_lock.h b/libc/private/bionic_lock.h
index eebfeff54..410e637d7 100644
--- a/libc/private/bionic_lock.h
+++ b/libc/private/bionic_lock.h
@@ -78,7 +78,7 @@ class Lock {
class LockGuard {
public:
- LockGuard(Lock& lock) : lock_(lock) {
+ explicit LockGuard(Lock& lock) : lock_(lock) {
lock_.lock();
}
~LockGuard() {