summaryrefslogtreecommitdiff
path: root/libc/system_properties/system_properties.cpp
diff options
context:
space:
mode:
authorThe Android Open Source Project <initial-contribution@android.com>2021-08-12 12:03:24 -0700
committerXin Li <delphij@google.com>2021-08-12 22:45:46 +0000
commitad19c87f806d8cc30f3dd38b2cf8b2093eb04d3a (patch)
tree93d699e33848416768e81412a3b42677c161c6d4 /libc/system_properties/system_properties.cpp
parent29045b3d7b8c940c84db5311958ab36530a22ed7 (diff)
parentc75fbc7b8a7a04feacab54cffc1c3129e0e4d769 (diff)
Merge ab/7633965
Bug: 169893837 Merged-In: Ic7a83fb01a39113d408ed0c95d27f694d5a2649c Change-Id: I4494985e98790e8934f10c8ba6f6f2207b3050ab
Diffstat (limited to 'libc/system_properties/system_properties.cpp')
-rw-r--r--libc/system_properties/system_properties.cpp10
1 files changed, 0 insertions, 10 deletions
diff --git a/libc/system_properties/system_properties.cpp b/libc/system_properties/system_properties.cpp
index 344c8383f..1cb15c3df 100644
--- a/libc/system_properties/system_properties.cpp
+++ b/libc/system_properties/system_properties.cpp
@@ -46,7 +46,6 @@
#include "system_properties/context_node.h"
#include "system_properties/prop_area.h"
#include "system_properties/prop_info.h"
-#include "system_properties/prop_trace.h"
#define SERIAL_DIRTY(serial) ((serial)&1)
#define SERIAL_VALUE_LEN(serial) ((serial) >> 24)
@@ -128,9 +127,6 @@ const prop_info* SystemProperties::Find(const char* name) {
return nullptr;
}
- SyspropTrace trace(name, nullptr /* prop_value */, nullptr /* prop_info */,
- PropertyAction::kPropertyFind);
-
prop_area* pa = contexts_->GetPropAreaForName(name);
if (!pa) {
async_safe_format_log(ANDROID_LOG_WARN, "libc", "Access denied finding property \"%s\"", name);
@@ -205,10 +201,6 @@ void SystemProperties::ReadCallback(const prop_info* pi,
// Read only properties don't need to copy the value to a temporary buffer, since it can never
// change. We use relaxed memory order on the serial load for the same reason.
if (is_read_only(pi->name)) {
- // The 2nd argument is not required for read-only property tracing, as the
- // value can be obtained via pi->value or pi->long_value().
- SyspropTrace trace(pi->name, nullptr /* prop_value */, pi /* prop_info */,
- PropertyAction::kPropertyGetReadOnly);
uint32_t serial = load_const_atomic(&pi->serial, memory_order_relaxed);
if (pi->is_long()) {
callback(cookie, pi->name, pi->long_value(), serial);
@@ -219,8 +211,6 @@ void SystemProperties::ReadCallback(const prop_info* pi,
}
char value_buf[PROP_VALUE_MAX];
- SyspropTrace trace(pi->name, value_buf, pi /* prop_info */,
- PropertyAction::kPropertyGetReadWrite);
uint32_t serial = ReadMutablePropertyValue(pi, value_buf);
callback(cookie, pi->name, value_buf, serial);
}