diff options
author | Christopher Ferris <cferris@google.com> | 2019-04-01 19:31:26 -0700 |
---|---|---|
committer | Christopher Ferris <cferris@google.com> | 2019-04-02 10:55:21 -0700 |
commit | c328e4465d12d760f5fbcb2daddf5fa4138f50b1 (patch) | |
tree | fd91c386332bbe1198cb0bedc11505b76d146057 /libc/malloc_debug/tests/malloc_debug_config_tests.cpp | |
parent | 4699cf61746d37fc11c8eb8bdfc7eb296a476e4b (diff) |
Disable info messages by default for malloc debug.
Add a new option verbose for malloc debug that is not enabled by default.
This disables all of the info log messages. It turns out these log
messages can add a measurable amount of time and can change the boot up.
Bug: 129239269
Test: Adjusted unit tests pass.
Test: Verified no messages unless verbose option used.
Change-Id: I805cb7c8ecb44de88119574e59d784877cacc383
Diffstat (limited to 'libc/malloc_debug/tests/malloc_debug_config_tests.cpp')
-rw-r--r-- | libc/malloc_debug/tests/malloc_debug_config_tests.cpp | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/libc/malloc_debug/tests/malloc_debug_config_tests.cpp b/libc/malloc_debug/tests/malloc_debug_config_tests.cpp index fb54ee54f..42d1415ac 100644 --- a/libc/malloc_debug/tests/malloc_debug_config_tests.cpp +++ b/libc/malloc_debug/tests/malloc_debug_config_tests.cpp @@ -743,3 +743,21 @@ TEST_F(MallocDebugConfigTest, trigger_abort_fail) { "which does not take a value\n"); ASSERT_STREQ((log_msg + usage_string).c_str(), getFakeLogPrint().c_str()); } + +TEST_F(MallocDebugConfigTest, verbose) { + ASSERT_TRUE(InitConfig("verbose")) << getFakeLogPrint(); + ASSERT_EQ(VERBOSE, config->options()); + + ASSERT_STREQ("", getFakeLogBuf().c_str()); + ASSERT_STREQ("", getFakeLogPrint().c_str()); +} + +TEST_F(MallocDebugConfigTest, trigger_verbose_fail) { + ASSERT_FALSE(InitConfig("verbose=200")) << getFakeLogPrint(); + + ASSERT_STREQ("", getFakeLogBuf().c_str()); + std::string log_msg( + "6 malloc_debug malloc_testing: value set for option 'verbose' " + "which does not take a value\n"); + ASSERT_STREQ((log_msg + usage_string).c_str(), getFakeLogPrint().c_str()); +} |