summaryrefslogtreecommitdiff
path: root/libc/malloc_debug/malloc_debug.cpp
diff options
context:
space:
mode:
authorRyan Prichard <rprichard@google.com>2019-10-14 16:58:53 -0700
committerRyan Prichard <rprichard@google.com>2019-10-16 19:43:47 +0000
commit2c809c4f90dd3d05c8d3c4966a69adc479fca63d (patch)
tree9be12e016201bcd8069e8215c8874cd6d4b97164 /libc/malloc_debug/malloc_debug.cpp
parent2d295d3248602f6c0b8f7e738ba9c67ea9569366 (diff)
Cleanup linker unwinder integration
The linker shouldn't throw exceptions, but because it links with libc++_static.a, there are code paths that could throw an exception. On those code paths, the unwinder needs to lookup EH information for the linker binary, and the linker had two inconsistent ways of doing this: * dl_iterate_phdr (for libgcc): dlfcn.cpp defined a linker-internal version of this API that forwarded to __loader_dl_iterate_phdr * __gnu_Unwind_Find_exidx (for arm32 libgcc): linker_exidx_static.c was an old, broken copy of exidx_static.c that used __exidx_start/__exidx_end symbols. (The file should have used the addresses of the symbols rather than their contents.) The linker's data structures might be in an inconsistent state at a point where exceptions are thrown, so it seems better to limit its unwinder to just the linker binary's EH info. Rather than forward the dl* EH APIs, link in the static-binary versions from libc_unwind_static.a. That library is already part of libc_nomalloc.a, but include it directly with whole_static_libs so that __gnu_Unwind_Find_exidx is defined when we're using libgcc on arm32. Try to link in libunwind_llvm.a into the arm32 linker binary so we're using the same unwinder as normal arm32 binaries. I'm not sure the library will appear in the right order, but maybe it doesn't matter given LLD's unconventional archive linking semantics. Test: bionic unit tests Test: "readelf --dyn-syms linker" reports no UNDEF symbols Test: "readelf -r linker" reports only relative relocations Bug: none Change-Id: I5982ec830ba0f15d066536de24f6cd7e9503498b Merged-In: I5982ec830ba0f15d066536de24f6cd7e9503498b Exempt-From-Owner-Approval: cherry pick (cherry picked from commit e2892cade5d01de8d216a73f621bac8833686895)
Diffstat (limited to 'libc/malloc_debug/malloc_debug.cpp')
0 files changed, 0 insertions, 0 deletions