summaryrefslogtreecommitdiff
path: root/libc/bionic/bionic_appcompat.cpp
diff options
context:
space:
mode:
authorPeter Collingbourne <pcc@google.com>2021-03-25 11:46:44 -0700
committerPeter Collingbourne <pcc@google.com>2021-03-25 14:07:33 -0700
commit811d180e892f757d052cf9d6c6b7494a8c4a8c2f (patch)
tree538306b08c5a363558c49c103266d6eeec62b2a7 /libc/bionic/bionic_appcompat.cpp
parenteb33b5b7a8852003756fcd645c238dae193410d6 (diff)
Reset PAC keys on thread creation instead of on zygote fork.
Resetting PAC keys on fork appears to lead to a number of problems. One problem is that we are constrained in where we can run C++ code after forking, and with ART those places are implementation-defined. For example, in app zygotes, ART turns out to insert "interpreter frames" in the stack trace. Returning into these interpreter frames may lead to crashes due to failing the ROP protection check on return. It seems better to reset keys on thread creation instead. We only need to reset IA because only this key needs to be reset for reverse-edge PAC, and resetting the other keys may be incompatible with future ABIs. Chrome (and potentially other applications) has a sandbox that prevents the use of the prctl, so we restrict its use to applications targeting S and above. Bug: 183024045 Change-Id: I1e6502a7d7df319d424e2b0f653aad9a343ae71b
Diffstat (limited to 'libc/bionic/bionic_appcompat.cpp')
0 files changed, 0 insertions, 0 deletions