diff options
author | Jeremy Compostella <jeremy.compostella@intel.com> | 2018-04-10 16:16:14 -0700 |
---|---|---|
committer | Jeremy Compostella <jeremy.compostella@intel.com> | 2018-04-12 14:00:43 -0700 |
commit | 611ad621c670a94dadf51562b6256b24f1247981 (patch) | |
tree | b3eba3e1135aaa45d353a174c9e159c2a3394b06 /libc/async_safe/async_safe_log.cpp | |
parent | 48227e66026724f9a94d9ff9cdef0aacae75b3a9 (diff) |
Revert "Add 64-bit slm optimized strlcpy and srlcat."
This reverts commit 2e7145c048e15bf6646befd70aa08d1bfe7b6c26.
When src is at the end page, the sse2 strlcpy SSE2 optimized version
can issue a movdqu instruction that can cross the page boundary. If
the next page is not allocated to that process, it leads to
segmentation fault. This is a rare but has be caught multiple times
during robustness testing.
We isolated a way to reproduce that issue outside of an Android device
and we have been able to resolve this particular case. However, we
ran some additional compliance and robustness tests and found several
other similar page crossing issues with this implementation.
In conclusion, this optimization needs to be re-written from scratch
because its design is at cause. In the meantime, it is better to
remove it.
Change-Id: If90450de430ba9b7cd9282a422783beabd701f3d
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Diffstat (limited to 'libc/async_safe/async_safe_log.cpp')
0 files changed, 0 insertions, 0 deletions