diff options
| author | Ryan Prichard <rprichard@google.com> | 2018-10-01 18:35:46 -0700 |
|---|---|---|
| committer | Ryan Prichard <rprichard@google.com> | 2018-10-08 13:27:16 -0700 |
| commit | 0adf09b3705c54733e46ace3b6cf08b78533729e (patch) | |
| tree | 50df5c98cacf4f4619940196d1a3362fc6dd778e /libc/async_safe/async_safe_log.cpp | |
| parent | 773c697f815d43182adf1eb430f4899255088d6b (diff) | |
linker: fix invalid zip file handling
The argument to CloseArchive has type ZipArchiveHandle, but we're
passing it a ZipArchiveHandle*. The compiler doesn't detect the type
mismatch because ZipArchiveHandle is a typedef for void*.
Remove a duplicate close() call:
The fourth argument to OpenArchiveFd is "bool assume_ownership = true".
Even if the function fails, ownership of the fd is still transferred to
a ZipArchive object that's deleted when this code calls CloseArchive.
AFAIK, this code path is rarely or never hit.
Bug: none
Test: manual (eventually, 'linker64 /system!/foo')
Change-Id: I95d79809b6e118fb3c39c7b98b8055c8e324db1a
Diffstat (limited to 'libc/async_safe/async_safe_log.cpp')
0 files changed, 0 insertions, 0 deletions