diff options
author | Elliott Hughes <enh@google.com> | 2021-02-04 16:58:13 -0800 |
---|---|---|
committer | Elliott Hughes <enh@google.com> | 2021-02-04 17:01:55 -0800 |
commit | f9cfecf3d4d848e247dc8bdc486ed227bff7315f (patch) | |
tree | 00f1b5a19b7acaa16783ea14361d156a38a98989 /benchmarks/malloc_sql_benchmark.cpp | |
parent | 15ade069b10f7f5291e48c01db2da4852dae04b7 (diff) |
Fix freopen() where the path is null.
This has been in the standard since C99, but we've never supported it
before. It's apparently used by SPIRV-Tools.
I tried implementing this the other way (with fcntl(2)) first, but
eventually realized that that's more complicated and gives worse
results. This implementation assumes that /proc is mounted, but so much
of libc relies on that at this point that I don't think there's any
realistic case where the fcntl(2) implementation would be preferable,
and there are many where it's not.
The fact that no-one's mentioned this until now suggests that it's not a
heavily used feature anyway.
I've also replaced AssertCloseOnExec() with a CloseOnExec()
boolean-valued function instead, because it's really annoying getting
assertion failures that don't point you at the test line in question,
and instead point to some common helper code.
Test: treehugger
Change-Id: Ia2e53bf2664a4f782581042054ecd492830e2aed
Diffstat (limited to 'benchmarks/malloc_sql_benchmark.cpp')
0 files changed, 0 insertions, 0 deletions