diff options
author | Ryan Prichard <rprichard@google.com> | 2021-02-10 23:31:31 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2021-02-10 23:31:31 +0000 |
commit | ef0ec82684ea52ee3a13db8df9103ca314ea17aa (patch) | |
tree | 0f1e1eac8db14d78a10e31b7d2b97fcc92a5b40f | |
parent | 8460308d11ba6129bea6000cc4fc1a58795c82db (diff) | |
parent | cdace2f2275694075c03ac90a80c990387807588 (diff) |
Merge "Revert "Disable signal frame unwinding tests on arm64""
-rw-r--r-- | tests/stack_unwinding_test.cpp | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/tests/stack_unwinding_test.cpp b/tests/stack_unwinding_test.cpp index 7fb22471c..0ff6f30a6 100644 --- a/tests/stack_unwinding_test.cpp +++ b/tests/stack_unwinding_test.cpp @@ -82,7 +82,7 @@ struct UnwindData { static UnwindData g_unwind_data; -__attribute__((unused)) static void noinline UnwindSignalHandler(int) { +static void noinline UnwindSignalHandler(int) { _Unwind_Backtrace(FrameCounter, &g_unwind_data.handler_frame_count); g_unwind_data.handler_one_deeper_frame_count = unwind_one_frame_deeper(); @@ -98,7 +98,7 @@ static void verify_unwind_data(const UnwindData& unwind_data) { EXPECT_EQ(unwind_data.handler_frame_count + 1, unwind_data.handler_one_deeper_frame_count); } -__attribute__((unused)) static void noinline UnwindTest() { +static void noinline UnwindTest() { g_unwind_data = {}; _Unwind_Backtrace(FrameCounter, &g_unwind_data.expected_frame_count); @@ -112,24 +112,14 @@ __attribute__((unused)) static void noinline UnwindTest() { } TEST(stack_unwinding, unwind_through_signal_frame) { -#if defined(__aarch64__) - // A newer libunwind.a update should restore signal frame unwinding on arm64. - GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717"; -#else ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler); UnwindTest(); -#endif } // On LP32, the SA_SIGINFO flag gets you __restore_rt instead of __restore. TEST(stack_unwinding, unwind_through_signal_frame_SA_SIGINFO) { -#if defined(__aarch64__) - // A newer libunwind.a update should restore signal frame unwinding on arm64. - GTEST_SKIP() << "signal frame unwinding temporarily broken on arm64 -- b/153025717"; -#else ScopedSignalHandler ssh(SIGUSR1, UnwindSignalHandler, SA_SIGINFO); UnwindTest(); -#endif } |