1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
|
/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import java.lang.reflect.Method;
/**
* Tests properties of some string operations represented by intrinsics.
*/
public class Main {
static final String ABC = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
static final String XYZ = "XYZ";
//
// Variant intrinsics remain in the loop, but invariant references are hoisted out of the loop.
//
/// CHECK-START: int Main.liveIndexOf() licm (before)
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOf loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOfAfter loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOf loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOfAfter loop:{{B\d+}} outer_loop:none
//
/// CHECK-START: int Main.liveIndexOf() licm (after)
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOf loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOfAfter loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOf loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOfAfter loop:none
static int liveIndexOf() {
int k = ABC.length() + XYZ.length(); // does LoadString before loops
for (char c = 'A'; c <= 'Z'; c++) {
k += ABC.indexOf(c);
}
for (char c = 'A'; c <= 'Z'; c++) {
k += ABC.indexOf(c, 4);
}
for (char c = 'A'; c <= 'Z'; c++) {
k += ABC.indexOf(XYZ);
}
for (char c = 'A'; c <= 'Z'; c++) {
k += ABC.indexOf(XYZ, 2);
}
return k;
}
//
// All dead intrinsics can be removed completely.
//
/// CHECK-START: int Main.deadIndexOf() dead_code_elimination$initial (before)
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOf loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringIndexOfAfter loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOf loop:{{B\d+}} outer_loop:none
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOfAfter loop:{{B\d+}} outer_loop:none
//
/// CHECK-START: int Main.deadIndexOf() dead_code_elimination$initial (after)
/// CHECK-NOT: InvokeVirtual intrinsic:StringIndexOf
/// CHECK-NOT: InvokeVirtual intrinsic:StringIndexOfAfter
/// CHECK-NOT: InvokeVirtual intrinsic:StringStringIndexOf
/// CHECK-NOT: InvokeVirtual intrinsic:StringStringIndexOfAfter
static int deadIndexOf() {
int k = ABC.length() + XYZ.length(); // does LoadString before loops
for (char c = 'A'; c <= 'Z'; c++) {
int d = ABC.indexOf(c);
}
for (char c = 'A'; c <= 'Z'; c++) {
int d = ABC.indexOf(c, 4);
}
for (char c = 'A'; c <= 'Z'; c++) {
int d = ABC.indexOf(XYZ);
}
for (char c = 'A'; c <= 'Z'; c++) {
int d = ABC.indexOf(XYZ, 2);
}
return k;
}
//
// Explicit null check on receiver, implicit null check on argument prevents hoisting.
//
/// CHECK-START: int Main.indexOfExceptions(java.lang.String, java.lang.String) licm (after)
/// CHECK-DAG: <<String:l\d+>> NullCheck loop:<<Loop:B\d+>> outer_loop:none
/// CHECK-DAG: InvokeVirtual [<<String>>,{{l\d+}}] intrinsic:StringStringIndexOf loop:<<Loop>> outer_loop:none
static int indexOfExceptions(String s, String t) {
int k = 0;
for (char c = 'A'; c <= 'Z'; c++) {
k += s.indexOf(t);
}
return k;
}
//
// Allows combining of returned "this". Also ensures that similar looking append() calls
// are not combined somehow through returned result.
//
/// CHECK-START: int Main.bufferLen2() instruction_simplifier (before)
/// CHECK-DAG: <<New:l\d+>> NewInstance
/// CHECK-DAG: <<String1:l\d+>> LoadString
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBufferAppend
/// CHECK-DAG: <<String2:l\d+>> LoadString
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [{{l\d+}},<<String2>>] intrinsic:StringBufferAppend
/// CHECK-DAG: InvokeVirtual [{{l\d+}}] intrinsic:StringBufferLength
//
/// CHECK-START: int Main.bufferLen2() instruction_simplifier (after)
/// CHECK-DAG: <<New:l\d+>> NewInstance
/// CHECK-DAG: <<String1:l\d+>> LoadString
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBufferAppend
/// CHECK-DAG: <<String2:l\d+>> LoadString
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [<<New>>,<<String2>>] intrinsic:StringBufferAppend
/// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBufferLength
static int bufferLen2() {
StringBuffer s = new StringBuffer();
return s.append("x").append("y").length();
}
static int bufferLen2Smali() throws Exception {
Class<?> c = Class.forName("Smali");
Method m = c.getMethod("bufferLen2");
return (Integer) m.invoke(null);
}
//
// Allows combining of returned "this". Also ensures that similar looking append() calls
// are not combined somehow through returned result.
//
/// CHECK-START: int Main.builderLen2() instruction_simplifier (before)
/// CHECK-DAG: <<New:l\d+>> NewInstance
/// CHECK-DAG: <<String1:l\d+>> LoadString
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBuilderAppendString
/// CHECK-DAG: <<String2:l\d+>> LoadString
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [{{l\d+}},<<String2>>] intrinsic:StringBuilderAppendString
/// CHECK-DAG: InvokeVirtual [{{l\d+}}] intrinsic:StringBuilderLength
//
/// CHECK-START: int Main.builderLen2() instruction_simplifier (after)
/// CHECK-DAG: <<New:l\d+>> NewInstance
/// CHECK-DAG: <<String1:l\d+>> LoadString
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBuilderAppendString
/// CHECK-DAG: <<String2:l\d+>> LoadString
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [<<New>>,<<String2>>] intrinsic:StringBuilderAppendString
/// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBuilderLength
static int builderLen2() {
StringBuilder s = new StringBuilder();
return s.append("x").append("y").length();
}
static int builderLen2Smali() throws Exception {
Class<?> c = Class.forName("Smali");
Method m = c.getMethod("builderLen2");
return (Integer) m.invoke(null);
}
//
// Similar situation in a loop.
//
/// CHECK-START: int Main.bufferLoopAppender() instruction_simplifier (before)
/// CHECK-DAG: <<New:l\d+>> NewInstance loop:none
/// CHECK-DAG: <<String1:l\d+>> LoadString loop:<<Loop:B\d+>>
/// CHECK-DAG: <<Null1:l\d+>> NullCheck [<<New>>] loop:<<Loop>>
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<Null1>>,<<String1>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: <<String2:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [{{l\d+}},<<String2>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: <<String3:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append3:l\d+>> InvokeVirtual [{{l\d+}},<<String3>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual [{{l\d+}}] intrinsic:StringBufferLength loop:none
//
/// CHECK-START: int Main.bufferLoopAppender() instruction_simplifier (after)
/// CHECK-DAG: <<New:l\d+>> NewInstance loop:none
/// CHECK-DAG: <<String1:l\d+>> LoadString loop:<<Loop:B\d+>>
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: <<String2:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [<<New>>,<<String2>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: <<String3:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append3:l\d+>> InvokeVirtual [<<New>>,<<String3>>] intrinsic:StringBufferAppend loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBufferLength loop:none
static int bufferLoopAppender() {
StringBuffer b = new StringBuffer();
for (int i = 0; i < 10; i++) {
b.append("x").append("y").append("z");
}
return b.length();
}
static int bufferLoopAppenderSmali() throws Exception {
Class<?> c = Class.forName("Smali");
Method m = c.getMethod("bufferLoopAppender");
return (Integer) m.invoke(null);
}
//
// Similar situation in a loop.
//
/// CHECK-START: int Main.builderLoopAppender() instruction_simplifier (before)
/// CHECK-DAG: <<New:l\d+>> NewInstance loop:none
/// CHECK-DAG: <<String1:l\d+>> LoadString loop:<<Loop:B\d+>>
/// CHECK-DAG: <<Null1:l\d+>> NullCheck [<<New>>] loop:<<Loop>>
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<Null1>>,<<String1>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: <<String2:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [{{l\d+}},<<String2>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: <<String3:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append3:l\d+>> InvokeVirtual [{{l\d+}},<<String3>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual [{{l\d+}}] intrinsic:StringBuilderLength loop:none
//
/// CHECK-START: int Main.builderLoopAppender() instruction_simplifier (after)
/// CHECK-DAG: <<New:l\d+>> NewInstance loop:none
/// CHECK-DAG: <<String1:l\d+>> LoadString loop:<<Loop:B\d+>>
/// CHECK-DAG: <<Append1:l\d+>> InvokeVirtual [<<New>>,<<String1>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: <<String2:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append2:l\d+>> InvokeVirtual [<<New>>,<<String2>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: <<String3:l\d+>> LoadString loop:<<Loop>>
/// CHECK-DAG: <<Append3:l\d+>> InvokeVirtual [<<New>>,<<String3>>] intrinsic:StringBuilderAppendString loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual [<<New>>] intrinsic:StringBuilderLength loop:none
static int builderLoopAppender() {
StringBuilder b = new StringBuilder();
for (int i = 0; i < 10; i++) {
b.append("x").append("y").append("z");
}
return b.length();
}
static int builderLoopAppenderSmali() throws Exception {
Class<?> c = Class.forName("Smali");
Method m = c.getMethod("bufferLoopAppender");
return (Integer) m.invoke(null);
}
//
// All calls in the loop-body and thus loop can be eliminated.
//
/// CHECK-START: int Main.bufferDeadLoop() instruction_simplifier (before)
/// CHECK-DAG: Phi loop:<<Loop:B\d+>>
/// CHECK-DAG: InvokeVirtual intrinsic:StringBufferToString loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOfAfter loop:<<Loop>>
//
/// CHECK-START: int Main.bufferDeadLoop() loop_optimization (after)
/// CHECK-NOT: Phi
/// CHECK-NOT: InvokeVirtual intrinsic:StringBufferToString
/// CHECK-NOT: InvokeVirtual intrinsic:StringStringIndexOfAfter
static int bufferDeadLoop() {
StringBuffer b = new StringBuffer();
String x = "x";
for (int i = 0; i < 10; i++) {
int d = b.toString().indexOf(x, 1);
}
return b.length();
}
//
// All calls in the loop-body and thus loop can be eliminated.
//
/// CHECK-START: int Main.builderDeadLoop() instruction_simplifier (before)
/// CHECK-DAG: Phi loop:<<Loop:B\d+>>
/// CHECK-DAG: InvokeVirtual intrinsic:StringBuilderToString loop:<<Loop>>
/// CHECK-DAG: InvokeVirtual intrinsic:StringStringIndexOfAfter loop:<<Loop>>
//
/// CHECK-START: int Main.builderDeadLoop() loop_optimization (after)
/// CHECK-NOT: Phi
/// CHECK-NOT: InvokeVirtual intrinsic:StringBuilderToString
/// CHECK-NOT: InvokeVirtual intrinsic:StringStringIndexOfAfter
static int builderDeadLoop() {
StringBuilder b = new StringBuilder();
String x = "x";
for (int i = 0; i < 10; i++) {
int d = b.toString().indexOf(x, 1);
}
return b.length();
}
// Regression b/33656359: StringBuffer x is passed to constructor of String
// (this caused old code to crash due to missing nullptr check).
//
/// CHECK-START: void Main.doesNothing() instruction_simplifier (before)
/// CHECK-DAG: InvokeVirtual intrinsic:StringBufferToString
//
/// CHECK-START: void Main.doesNothing() instruction_simplifier (after)
/// CHECK-DAG: InvokeVirtual intrinsic:StringBufferToString
static void doesNothing() {
StringBuffer x = new StringBuffer();
String y = new String(x);
x.toString();
}
public static void main(String[] args) throws Exception {
expectEquals(1865, liveIndexOf());
expectEquals(29, deadIndexOf());
try {
indexOfExceptions(null, XYZ);
throw new Error("Expected: NPE");
} catch (NullPointerException e) {
}
try {
indexOfExceptions(ABC, null);
throw new Error("Expected: NPE");
} catch (NullPointerException e) {
}
expectEquals(598, indexOfExceptions(ABC, XYZ));
expectEquals(2, bufferLen2());
expectEquals(2, bufferLen2Smali());
expectEquals(2, builderLen2());
expectEquals(2, builderLen2Smali());
expectEquals(30, bufferLoopAppender());
expectEquals(30, bufferLoopAppenderSmali());
expectEquals(30, builderLoopAppender());
expectEquals(30, builderLoopAppenderSmali());
expectEquals(0, bufferDeadLoop());
expectEquals(0, builderDeadLoop());
doesNothing();
System.out.println("passed");
}
private static void expectEquals(int expected, int result) {
if (expected != result) {
throw new Error("Expected: " + expected + ", found: " + result);
}
}
}
|
